core refactor #2503
Merged
core refactor #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/core-refactor
branch
from
249a0e4 to
8e8ebf2
Compare
tzemanovic
added a commit
that referenced
this pull request
Feb 2, 2024
tzemanovic
force-pushed
the
tomas/core-refactor
branch
from
4634fc3 to
1572a8a
Compare
tzemanovic
added a commit
that referenced
this pull request
Feb 5, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 6, 2024
* tomas/refactor-testing-addrs: changelog: add #2507 core: prevent from using addresses for testing in non-test code changelog: add #2506 gov: replace namada_state dep with namada_storage changelog: add #2503 update all core types usages core: flatten types mod update replay_protection usage core: factor out the ledger::replay_protection mod into a new crate core: refactor out ledger::eth_bridge mod changelog: add #2493 benches: fix the shell to update conversions on new epochs move shielded params from core into shielded_token move inflation from core to trans_token replace namada_state usage with namada_storage in token crates changelog: add #2482 refactor finalize_block PoS updates refactor finalize_block governance updates refactor finalize_block token updates
Closed
This was referenced Feb 9, 2024
Closed
tzemanovic
force-pushed
the
tomas/core-refactor
branch
from
1572a8a to
94d1a0b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 302 305 +3
Lines 103403 103356 -47
=======================================
- Hits 55198 55176 -22
+ Misses 48205 48180 -25 ☔ View full report in Codecov by Sentry. |
grarco
approved these changes
Feb 21, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 22, 2024
* tomas/core-refactor: changelog: add #2503 update all core types usages core: flatten types mod update replay_protection usage core: factor out the ledger::replay_protection mod into a new crate core: refactor out ledger::eth_bridge mod
tzemanovic
added a commit
that referenced
this pull request
Feb 22, 2024
This was referenced Feb 22, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 23, 2024
* tomas/core-refactor: changelog: add #2503 update all core types usages core: flatten types mod update replay_protection usage core: factor out the ledger::replay_protection mod into a new crate core: refactor out ledger::eth_bridge mod
tzemanovic
added a commit
that referenced
this pull request
Feb 23, 2024
batconjurer
reviewed
Feb 26, 2024
| @@ -572,13 +573,27 @@ macro_rules! impl_storage_traits { | |||
| impl_storage_traits!(WlStorage<D, H>); | |||
| impl_storage_traits!(TempWlStorage<'_, D, H>); | |||
|
|
|||
| impl<D, H> WithConversionState for WlStorage<D, H> | |||
There was a problem hiding this comment.
Does this really need a separate trait?
There was a problem hiding this comment.
I think so - it is used to replace the state dep in shielded_token with storage, which restricts what the crate can access. The idea is to use a similar approach (with mocking when needed) to remove inter-sub-system dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #2483
Indicate on which release or other PRs this topic is based on
#2493 - diff https://github.com/anoma/namada/pull/2503/files/00cddd4c2585829d7e1b4e9bbded892b3b80d2d2..94d1a0b2048bb33fd2043aa27a69d388d965163a
Checklist before merging to
draft