Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor token crates #2493

Merged
merged 9 commits into from
Feb 27, 2024
Merged

refactor token crates #2493

merged 9 commits into from
Feb 27, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jan 31, 2024

Describe your changes

closes #2484

Indicate on which release or other PRs this topic is based on

#2482 - diff https://github.com/anoma/namada/pull/2493/files/fdafaa685f3cc0da98dc84a443a93314feffea7e..00cddd4c2585829d7e1b4e9bbded892b3b80d2d2

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic added the modularization Part of Namada's modularization effort label Jan 31, 2024
@tzemanovic tzemanovic force-pushed the tomas/refactor-token branch from f9d2361 to b986a66 Compare February 1, 2024 11:07
tzemanovic added a commit that referenced this pull request Feb 1, 2024
@tzemanovic tzemanovic force-pushed the tomas/refactor-token branch from b986a66 to 055c597 Compare February 1, 2024 13:22
@tzemanovic tzemanovic marked this pull request as ready for review February 1, 2024 13:22
@Fraccaman Fraccaman mentioned this pull request Feb 1, 2024
@tzemanovic tzemanovic mentioned this pull request Feb 1, 2024
2 tasks
@tzemanovic tzemanovic changed the title refactor token refactor token crates Feb 1, 2024
tzemanovic added a commit that referenced this pull request Feb 1, 2024
@tzemanovic tzemanovic force-pushed the tomas/refactor-token branch from 055c597 to e28fd86 Compare February 1, 2024 17:11
@tzemanovic tzemanovic mentioned this pull request Feb 5, 2024
tzemanovic added a commit that referenced this pull request Feb 5, 2024
@tzemanovic tzemanovic force-pushed the tomas/refactor-token branch from e28fd86 to cbbe6c2 Compare February 5, 2024 13:24
tzemanovic added a commit that referenced this pull request Feb 6, 2024
* tomas/refactor-testing-addrs:
  changelog: add #2507
  core: prevent from using addresses for testing in non-test code
  changelog: add #2506
  gov: replace namada_state dep with namada_storage
  changelog: add #2503
  update all core types usages
  core: flatten types mod
  update replay_protection usage
  core: factor out the ledger::replay_protection mod into a new crate
  core: refactor out ledger::eth_bridge mod
  changelog: add #2493
  benches: fix the shell to update conversions on new epochs
  move shielded params from core into shielded_token
  move inflation from core to trans_token
  replace namada_state usage with namada_storage in token crates
  changelog: add #2482
  refactor finalize_block PoS updates
  refactor finalize_block governance updates
  refactor finalize_block token updates
@brentstone brentstone mentioned this pull request Feb 8, 2024
This was referenced Feb 9, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 76.08696% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 53.40%. Comparing base (c733be2) to head (00cddd4).
Report is 79 commits behind head on main.

Files Patch % Lines
crates/core/src/event.rs 47.87% 49 Missing ⚠️
crates/proof_of_stake/src/lib.rs 78.69% 36 Missing ⚠️
crates/shielded_token/src/lib.rs 26.31% 14 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 6 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 89.47% 2 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 94.73% 1 Missing ⚠️
crates/shielded_token/src/conversion.rs 98.63% 1 Missing ⚠️
crates/tx/src/lib.rs 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2493      +/-   ##
==========================================
+ Coverage   53.38%   53.40%   +0.02%     
==========================================
  Files         302      305       +3     
  Lines      103403   103437      +34     
==========================================
+ Hits        55198    55239      +41     
+ Misses      48205    48198       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request Feb 22, 2024
* tomas/refactor-token:
  changelog: add #2493
  benches: fix the shell to update conversions on new epochs
  move shielded params from core into shielded_token
  move inflation from core to trans_token
  replace namada_state usage with namada_storage in token crates
tzemanovic added a commit that referenced this pull request Feb 23, 2024
* tomas/refactor-token:
  changelog: add #2493
  benches: fix the shell to update conversions on new epochs
  move shielded params from core into shielded_token
  move inflation from core to trans_token
  replace namada_state usage with namada_storage in token crates
@tzemanovic tzemanovic merged commit 0f5f2d4 into main Feb 27, 2024
14 of 17 checks passed
@tzemanovic tzemanovic deleted the tomas/refactor-token branch February 27, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modularization Part of Namada's modularization effort non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

token crates refactor
2 participants