Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token crates refactor #2484

Closed
Tracked by #2529
tzemanovic opened this issue Jan 31, 2024 · 0 comments · Fixed by #2493
Closed
Tracked by #2529

token crates refactor #2484

tzemanovic opened this issue Jan 31, 2024 · 0 comments · Fixed by #2493
Assignees
Labels
modularization Part of Namada's modularization effort pre-mainnet Must happen before mainnet. refactor / code quality

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Jan 31, 2024

  • move inflation from core into token crate
  • find a way to move ConversionState to token crates (it's in core b/c it's currently being used in namada_storage) to unblock the next point
  • move the core token types into the token crates - not feasible, there are still many other types in core that use token::Amount and/or token::DenominatedAmount
  • replace the namada_state dep with namada_storage (used in shielded token for conversion state)
  • move struct MaspParams into shielded_token
@tzemanovic tzemanovic added the modularization Part of Namada's modularization effort label Jan 31, 2024
@tzemanovic tzemanovic mentioned this issue Jan 31, 2024
2 tasks
@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modularization Part of Namada's modularization effort pre-mainnet Must happen before mainnet. refactor / code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants