Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core refactor #2483

Closed
Tracked by #2529
tzemanovic opened this issue Jan 31, 2024 · 0 comments · Fixed by #2503
Closed
Tracked by #2529

core refactor #2483

tzemanovic opened this issue Jan 31, 2024 · 0 comments · Fixed by #2503
Assignees
Labels
modularization Part of Namada's modularization effort pre-mainnet Must happen before mainnet. refactor / code quality

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Jan 31, 2024

There are couple left over things in  namada_core::ledger mod that can be moved out:

  • eth (only addresses that can go in core/src/types/address.rs or ethereum_bridge crate)
  • inflation can probably go into token crate - token crates refactor #2484
  • replay protection is spread out - it could maybe be its own crate
  • Flatten the core types  module so that we're just importing e.g. namada_core::dec  etc.

Also check and remove any unused deps.

@tzemanovic tzemanovic added modularization Part of Namada's modularization effort refactor / code quality labels Jan 31, 2024
@tzemanovic tzemanovic mentioned this issue Feb 1, 2024
2 tasks
@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modularization Part of Namada's modularization effort pre-mainnet Must happen before mainnet. refactor / code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants