-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gov refactor #2506
Merged
Merged
gov refactor #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Feb 2, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 5, 2024
tzemanovic
force-pushed
the
tomas/gov-refactor
branch
from
February 5, 2024 13:41
a030c11
to
b926403
Compare
tzemanovic
added a commit
that referenced
this pull request
Feb 6, 2024
* tomas/refactor-testing-addrs: changelog: add #2507 core: prevent from using addresses for testing in non-test code changelog: add #2506 gov: replace namada_state dep with namada_storage changelog: add #2503 update all core types usages core: flatten types mod update replay_protection usage core: factor out the ledger::replay_protection mod into a new crate core: refactor out ledger::eth_bridge mod changelog: add #2493 benches: fix the shell to update conversions on new epochs move shielded params from core into shielded_token move inflation from core to trans_token replace namada_state usage with namada_storage in token crates changelog: add #2482 refactor finalize_block PoS updates refactor finalize_block governance updates refactor finalize_block token updates
Closed
This was referenced Feb 9, 2024
Closed
tzemanovic
force-pushed
the
tomas/gov-refactor
branch
from
February 19, 2024 15:06
b926403
to
224798f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2506 +/- ##
==========================================
- Coverage 53.38% 53.37% -0.01%
==========================================
Files 302 305 +3
Lines 103403 103341 -62
==========================================
- Hits 55198 55162 -36
+ Misses 48205 48179 -26 ☔ View full report in Codecov by Sentry. |
grarco
approved these changes
Feb 21, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 22, 2024
* tomas/gov-refactor: changelog: add #2506 gov: replace namada_state dep with namada_storage
This was referenced Feb 22, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 23, 2024
* tomas/gov-refactor: changelog: add #2506 gov: replace namada_state dep with namada_storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #2485
Indicate on which release or other PRs this topic is based on
#2503 - diff https://github.com/anoma/namada/pull/2506/files/94d1a0b2048bb33fd2043aa27a69d388d965163a..224798f39fa031f82e958544e2e3bc9424488814
Checklist before merging to
draft