Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gov refactor #2506

Merged
merged 17 commits into from
Feb 27, 2024
Merged

gov refactor #2506

merged 17 commits into from
Feb 27, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Feb 2, 2024

Describe your changes

closes #2485

Indicate on which release or other PRs this topic is based on

#2503 - diff https://github.com/anoma/namada/pull/2506/files/94d1a0b2048bb33fd2043aa27a69d388d965163a..224798f39fa031f82e958544e2e3bc9424488814

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

tzemanovic added a commit that referenced this pull request Feb 2, 2024
@tzemanovic tzemanovic marked this pull request as ready for review February 2, 2024 09:49
@tzemanovic tzemanovic mentioned this pull request Feb 2, 2024
2 tasks
@tzemanovic tzemanovic added the modularization Part of Namada's modularization effort label Feb 2, 2024
This was referenced Feb 2, 2024
tzemanovic added a commit that referenced this pull request Feb 5, 2024
tzemanovic added a commit that referenced this pull request Feb 6, 2024
* tomas/refactor-testing-addrs:
  changelog: add #2507
  core: prevent from using addresses for testing in non-test code
  changelog: add #2506
  gov: replace namada_state dep with namada_storage
  changelog: add #2503
  update all core types usages
  core: flatten types mod
  update replay_protection usage
  core: factor out the ledger::replay_protection mod into a new crate
  core: refactor out ledger::eth_bridge mod
  changelog: add #2493
  benches: fix the shell to update conversions on new epochs
  move shielded params from core into shielded_token
  move inflation from core to trans_token
  replace namada_state usage with namada_storage in token crates
  changelog: add #2482
  refactor finalize_block PoS updates
  refactor finalize_block governance updates
  refactor finalize_block token updates
@brentstone brentstone mentioned this pull request Feb 8, 2024
This was referenced Feb 9, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 77.09191% with 167 lines in your changes are missing coverage. Please review.

Project coverage is 53.37%. Comparing base (c733be2) to head (224798f).
Report is 79 commits behind head on main.

Files Patch % Lines
crates/core/src/event.rs 47.87% 49 Missing ⚠️
crates/proof_of_stake/src/lib.rs 78.94% 36 Missing ⚠️
crates/storage/src/mockdb.rs 51.42% 17 Missing ⚠️
crates/shielded_token/src/lib.rs 26.31% 14 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 7 Missing ⚠️
crates/governance/src/storage/mod.rs 46.15% 7 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 6 Missing ⚠️
crates/storage/src/lib.rs 87.50% 4 Missing ⚠️
crates/core/src/ethereum_events.rs 0.00% 3 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 3 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2506      +/-   ##
==========================================
- Coverage   53.38%   53.37%   -0.01%     
==========================================
  Files         302      305       +3     
  Lines      103403   103341      -62     
==========================================
- Hits        55198    55162      -36     
+ Misses      48205    48179      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request Feb 22, 2024
* tomas/gov-refactor:
  changelog: add #2506
  gov: replace namada_state dep with namada_storage
tzemanovic added a commit that referenced this pull request Feb 23, 2024
* tomas/gov-refactor:
  changelog: add #2506
  gov: replace namada_state dep with namada_storage
@tzemanovic tzemanovic merged commit f31c693 into main Feb 27, 2024
16 of 17 checks passed
@tzemanovic tzemanovic deleted the tomas/gov-refactor branch February 27, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modularization Part of Namada's modularization effort non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

governance crate refactor
2 participants