refactor finalize block

[tzemanovic]

Describe your changes

Refactored token, gov and PoS sub-systems integration in finalize block. The token and PoS logic is moved into their respective crates. Gov proposal exec depends on the shell as well as IBC and PoS so this is kept in crates/apps/src/lib/node/ledger/shell/governance.rs for now.

Indicate on which release or other PRs this topic is based on

0.31.5

Checklist before merging to draft

• I have added a changelog
• Git history is in acceptable state

[codecov]

Codecov Report

Attention: Patch coverage is 74.35159% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 53.39%. Comparing base (c733be2) to head (fdafaa6).
Report is 81 commits behind head on main.

❗ Current head fdafaa6 differs from pull request most recent head f338483. Consider uploading reports for the commit f338483 to get more accurate results

Files	Patch %	Lines
crates/core/src/event.rs	47.87%	49 Missing ⚠️
crates/proof_of_stake/src/lib.rs	78.69%	36 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs	89.47%	2 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs	94.73%	1 Missing ⚠️
crates/tx/src/lib.rs	96.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
+ Coverage   53.38%   53.39%   +0.01%     
==========================================
  Files         302      303       +1     
  Lines      103403   103433      +30     
==========================================
+ Hits        55198    55231      +33     
+ Misses      48205    48202       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[grarco]

Looks good to me, thank you!

[brentstone]

Can we also move

namada/crates/apps/src/lib/node/ledger/shell/finalize_block.rs

Lines 647 to 653 in fdafaa6

	for ibc_event in self.wl_storage.write_log_mut().take_ibc_events() {
	let mut event = Event::from(ibc_event.clone());
	// Add the height for IBC event query
	let height = self.wl_storage.storage.get_last_block_height() + 1;
	event["height"] = height.to_string();
	response.events.push(event);
	}

out of apply_inflation? I suspect it may have been incorrectly placed into this function, it can at least go right into finalize_block::finalize_block or some other function, but it has nothing to do with inflation.

[brentstone]

Would it also be safer to call governance::finalize_block before token::finalize_block in case we want governance to execute changes before MASP update_allowed_conversions is called ever?

[brentstone]

Also, perhaps we could move proof_of_stake::log_block_rewards to proof_of_stake::rewards::log_block_rewards and proof_of_stake::record_slashes_from_evidence to proof_of_stake::slashing::record_slashes_from_evidence.

[tzemanovic]

Would it also be safer to call governance::finalize_block before token::finalize_block in case we want governance to execute changes before MASP update_allowed_conversions is called ever?

Yeah, good call

[tzemanovic]

@yito88 it looks like the ibc events were in the wrong place and they would have only been applied on new epochs