Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en-GB language pack package correction (fix inconsistency) #29

Closed
wants to merge 30 commits into from

Conversation

andrepereiradasilva
Copy link
Owner

Pull Request for New Issue.

Summary of Changes

As detected in PR joomla#9744, there is an inconsistency in the en-GB language extensions.

The default language (en-GB) should have 3 extensions like any other language pack:

  1. type = language | client = Site: For the site site language
  2. type = language | client = Administrator: For the administrator site language
  3. type = package | client = Site: For the whole en-GB language package

But, only extensions "1." (en-GB site language) and "2." (en-GB admin language) exist in Joomla core default database.

The extension "3." (pkg_en-GB language package), although is has a manifest file, doesn't have an extension in Joomla core default database.

Note that this is the only manifest file in the whole Joomla core that doesn't has an extension in the database, and for consistency it should.

This generates some inconsistencies, for instance the update server is declared in the extension "3." (en-GB language package) manifest file, but in the database is linked to extension "1." (en-GB site language).
Extension "1." (en-GB site language) doesn't have update servers in his manifest file, because is a extension of language type.

So, this PR adds the "pkg_en-GB language package" extension to new joomla installation, also adds it to the upgrade process and makes the necessary adjustments in the code.

image

image

Testing Instructions

New installation
  1. Install Joomla with this package https://github.com/andrepereiradasilva/joomla-cms/archive/en-gb-package-correc.zip
  2. Add some languages in the end of the installation. Check if they are installed correctly.
  3. Go to admin. "Extensions -> Manage -> Install languages"
  4. Install some languages. Check if everything is fine
  5. Go to "Extensions -> Manage -> Update Sites" and check if all "Accredited Joomla! Translations" are o the type "Package", including the en-GB one.
  6. Go to "Extensions -> Manage -> Manage", filter by package and check if and languages are there. Including the en-GB (should be blocked).
Upgrade
  1. Use 3.5.1 or latest staging
  2. Install patch Joomla! Update: reinstall Joomla! and Update & Install features | seccond try joomla/joomla-cms#9612 so you can upload joomla with upload
  3. Go to Joomla update component
  4. Update joomla with this custom 3.5.5 package https://github.com/andrepereiradasilva/update.joomla.org/raw/master/Joomla_3.5.1_to_3.5.5-Stable-Patch_Package.zip
  5. Repeat the same steps "3." to "6." of the "New installation" test.

@andrepereiradasilva andrepereiradasilva deleted the en-gb-package-correc branch April 10, 2016 16:27
andrepereiradasilva pushed a commit that referenced this pull request Apr 12, 2016
Check for empty jquery object before value length

Thanks @richard67
andrepereiradasilva pushed a commit that referenced this pull request Jun 3, 2017
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
andrepereiradasilva pushed a commit that referenced this pull request Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant