forked from joomla/joomla-cms
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
en-GB language pack package correction (fix inconsistency) #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepereiradasilva
pushed a commit
that referenced
this pull request
Apr 12, 2016
Check for empty jquery object before value length Thanks @richard67
andrepereiradasilva
pushed a commit
that referenced
this pull request
Jun 3, 2017
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
andrepereiradasilva
pushed a commit
that referenced
this pull request
Dec 24, 2018
Improve export logs + purge thanks @joomdonation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for New Issue.
Summary of Changes
As detected in PR joomla#9744, there is an inconsistency in the en-GB language extensions.
The default language (en-GB) should have 3 extensions like any other language pack:
But, only extensions "1." (en-GB site language) and "2." (en-GB admin language) exist in Joomla core default database.
The extension "3." (pkg_en-GB language package), although is has a manifest file, doesn't have an extension in Joomla core default database.
Note that this is the only manifest file in the whole Joomla core that doesn't has an extension in the database, and for consistency it should.
This generates some inconsistencies, for instance the update server is declared in the extension "3." (en-GB language package) manifest file, but in the database is linked to extension "1." (en-GB site language).
Extension "1." (en-GB site language) doesn't have update servers in his manifest file, because is a extension of language type.
So, this PR adds the "pkg_en-GB language package" extension to new joomla installation, also adds it to the upgrade process and makes the necessary adjustments in the code.
Testing Instructions
New installation
Upgrade