Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves hathor searchtools bugs and some regressions #35

Closed
wants to merge 14 commits into from
Closed

Solves hathor searchtools bugs and some regressions #35

wants to merge 14 commits into from

Conversation

andrepereiradasilva
Copy link
Owner

@andrepereiradasilva andrepereiradasilva commented Apr 22, 2016 •
edited
Loading

Pull Request for Regression and New Issue.

Summary of Changes

With all the changes in searchtools some filters have a wrong input filtering. Soem were caused by my PRs and many other were already there.

Anyhow, most of this problems only manifests itself in hathor.

As you see from the code changes, besides the input filtering, there are a series of inconsistensies that cause this problems.

This PR try to solve all problems with searchfilters that don't work properly, particluar in hathor.

Testing Instructions

First test on isis to confirm they are all working properly:

  1. Use latest staging and apply this PR
  2. Go to "Users" -> "Manage" and test the "state" and "activated" filters
  3. Go to "Users" -> "User notes" and test the "state" filter
  4. Go to "Content" -> "Categories" and test the "access" and the "language" filter (the "All" value in particular).
  5. Go to "Components" -> "Banners" -> "Banners" and test the "state" filter.
  6. Go to "Components" -> "Banners" -> "Tracks" and test the "type", the "client" and "category" filter.
  7. Go to "Components" -> "Contacts" -> "Contacts" and test the "access" and the "language" filter (the "All" value in particular).
  8. Go to "Components" -> "Newsfeeds" -> "Newsfeeds" and test the "category id", "access" and the "language" filter (the "All" value in particular).
  9. Go to "Extensions" -> "Modules" and test the "state" (the "All" value in particular) "language" filter (the "All" value in particular).
  10. Go to "Extensions" -> "Plugins" and test the "enabled" filter.
  11. Go to "Extensions" -> "Languages" -> "Enabled" and test the "state" filter (the "All" value in particular).
  12. Go to "Extensions" -> "Manage" -> "Manage" and test all the filters.

Now change the template to hathor and do the same tests.

Notes:

  • In the points abolse i only say to test the corrected filters, but if you find more problems please say so.

@andrepereiradasilva andrepereiradasilva changed the title Hathor searchtools bugs Solves hathor searchtools bugs and some regressions Apr 22, 2016
andrepereiradasilva pushed a commit that referenced this pull request Aug 14, 2016
@Ruchiranga @rdeutz
Google Summer of Code 2016 JavaScript Testing project (joomla#11420)
6021a45 
* Initial test environment setup with Jasmine, Karma and RequireJS

* Seperated test setup code from test logic

* Configured .travis.yml to run Karma

* Fixed typo in .travis.yml

* changes to .travis.yml

* Added karma requirejs module

* Removed unnecessary code in travis.yml

* Fixed missing code is travis.yml

* Removed 2 unused image files

* Improved code standards

* Modified travis.yml

* Issue 1 Cleaned the mess with changes bunch of to unrelated files

* Issue 1 Added newline at end of file

* Issue 4 Improved JCaption JavaScript tests

* New coeverage reporter plugin test with Travis

* Issue 1 Added karma-coerage reporter and configured it to display coverage on console

* Issue 1 Added and configured karma-verbose-reporter plugin

* Issue 1 Fixing verbose reporter config for travis

* Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures

* Issue 4 Improved code with suggestions made in the code review

* Issue 1 Added version for requirejs text plugin

* Issue 1 converted space indentations to tabs

* Issue 1 Fixed indentation in package.json

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 4 Improved code standards and jquer selector efficiency

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Removed spec folder

* Corejs tests (#15)

Tests for core.js

* Tests for permissions.js (#13)

* Test suite for permissions.js
* Added karma-jasmine-ajax plugin

* Added a container div for fixtures representing library name (#11)

* Added a container div for fixtures representing the library name

* CS - Removed an extra new line

* Permissions.js tests

Test for permissions

* Repeatable.js test suite

* Improvements to JCaption tests

* README.md update

* Modified readme file
* Made running tests easier by adding configuration for tests to run on npm test

* Core js Improvements

* Issue 9 Added jasmine spies and improved code
* Issue 9 Fixed an indentation issue

* Demo video on Youtube 

* Inserted the video demonstration link to the readme

* Issue 5 Added spies and made code improvements (#31)

* Issue 12 Improved code (#34)

* Repeatable.js Improvements (#35)

* Run Travis JavaScript tests on separated Matrix Build (#39)

* Only run Travis tests on PHP 7

* Fix base path issue

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Reverted README.md

* Synced README.md to the new version

* Synced README.md with new version

* Fixed indentations

* Synced README.md with 3.6 version

* Fixed indentations

* Fixed indentations
* Added newline at the end of travis-tests.sh

* Added missing sudo:false in .travis.yml
andrepereiradasilva pushed a commit that referenced this pull request Jun 3, 2017
@brianteeman @wilsonge
[codestyle] admin components xml files (joomla#15920)
6c66636 
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
andrepereiradasilva pushed a commit that referenced this pull request Jun 22, 2017
@yvesh @rdeutz
[Testing] Add basic setup and sample tests for Codeception System Tes…
5b6abe8 
…ts (joomla#16743)

* System tests with codeception 2.2

* System tests with codeception 2.2

* System tests with codeception 2.2

* System tests with codeception 2.2

* Instructions for testing

* Instructions for testing

* Remove useless header

* [tests] new convention for locating elements

Adds Gherkin Pages and Step Objects as sample of useage

* Update Codeception to 2.2.1

* Writing new composer.lock file for update

* Adding users.feature scenarios using gherkin

* Adding content.feature scenarios using gherkin

* Adding users.feature file

* Adding scenarios for access level and user group

* Adding Assert module for assertion

* Implementing Pageobject

* Passing $title and $content as a argument

* Implement step and page object in users.feature file

* Add missing pages

* New approach to manage suite configuration

* Fix the issue_#29 and issue_#31

* Fix the issue_#30

* Fix the issue #37

* Remove the commented code

* Every page object have the $url property

* Update Codeception to version 2.2.2

* Create a constant for waiting times

* Adding project information in README.md

* update readme

* Update README.md for TIMEOUT

* Checking if TIMEOUT is not already set

Pull Request for Issue #45 .

Update a constant for waiting times

It contains fix related to #47

* Using contants for timeouts

* Improvement in frontend feature

* improve the scenario

* correct typo and improvement

* Implement user frontend scenarios

* Updated travis to only run system tests and no unit tests

* add how to create snippets

* category Scenario for issue #35

* Fix missing call to Step object

* Move administrator login to the current page object pattern 

* Move administrator login to the current page object pattern
* Remove Given Joomla CMS is installed
* Update composer
* Fix LoginPage
* Fix missing call to step object
* Use genering url name for page variable

* Simplify users manager table xpath

* Fix typo error

* Allow robo to run individual .feature tests (#58)

* Allow robo tu run individual .feature tests

* Improve running individuals tests documentation

* Implement the categories scenario

* slove xpath issue and implement frontend scenario

* Handle waiting for iframe and menu edit view to save menu item

* Updating selenium to 2.53.1

* Updated travis integration for running tests (#60)

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Updated travis integration for running tests

* Working on Travis

* Working on Travis

* Working on Travis

* Working on Travis

* Adding docblocks and code style improvements

* Adding phpdoc header and code style improvement in acceptance tester
* [dockblock] Adding in Admin page object

* [dockblock] Adding dockblock in content manager page object

* [code style] Improve name of variable

* [dockblock] Adding dockblock in control panel page object
* [dockblock] Using AcceptanceTester.Page as a subpackage
* [dockblock] Adding dockblock in login page object
* [dockblock] Adding docblock in user acl page object
* [dockblock] Adding dockblock in user group page object
* [dockblock] Adding dockblock in user manager page object
* [code style] Adding code style improvement in acceptance tester class
* [docblock] Adding docblock in acceptance helper class
* [docblock] Adding docblock in functional and unit testing class
* [docblock] Adding docblocks and code style improvements in site page objects
* [code style] Adding docblock and code style improvements
* [code style] Adding code style improvement in acceptance tester
* [docblock] Adding docblock in content step object
* [docblock] Adding docblock and code style improvement in category step object
* Adding category feature execution using Robo
* [docblock] Adding docblock and code style improvement for category and menu page objects
* Rearrange tab based on latest joomla
* [docblock] Adding docblock and code style improvement in login and user step objects
* [docblock] Adding docblock and code style improvement in login and user step objects
* [docblock] Adding docblock and code style improvement in user frontend step objects
* Remove extra blank lines
* Remove comments from robo

* Using __DEPLOY_VERSION__ instead of static 3.7

* Forcing 127.0.0.1 for /etc/hosts in travis

* [code optimize] code optimization and remove duplicate codes (#65)

* [code optimize] Combine save method for category and content

* Using page object dynamically

* Revert "[code optimize] Combine save method for category and content"

This reverts commit 82682c5d57a14707c191736a57f22011c2fd54be.

* Usign dynamic wait for test string

* [duplicate] Handle duplicate code for user form

* Using common annotation for create new user

* [duplicate] Using common annotation for login in frontend scenarios

* [duplicate] Using page object method to have user with username

* [duplicate] Using page object method to have category with given title

* [duplicate] Using page object method to have article with given title

* [optimize] Reusing code by using oop concept

* Resolve error in creating instance

* Reuse fill article form code

* Create Admin step

* Using common method to search and select

* Using common method for see system message

* Using common method for search

* Remove duplicate code

* Remove duplicate code for delete and empty

* Using property from parent class

* Using Admin step as a parent class

* Cleanup acceptance tester

* Using generic page object properties

* Updating travis and Robo to the final structure

* Updating and moving codeception-build script

* Updating and moving codeception-build script

* Updating and moving codeception-build script

* Updating and moving codeception-build script

* Updating and moving codeception-build script

* Updating and moving codeception-build script

* Updating and moving codeception-build script

* change the tests with generic name (#68)

* change the tests with generic name

* Rename test user1 to User One

* Rename the email and login name

* Remove acceptance.suite.yml file from git list (#70)

* Remove acceptance.suite.yml file from git list

* Remove unnecessory _generated folder

* Fix issue #57 Update frontend_user tests  (#61)

* Fix issue_#57 Update frontend_user tests as per commented in PR #51

* [codestyle] Adding docblock and code style improvement in Robo and user frontend

* Verify in backend that user is created

* Fix scenario in user_frontend.feature to proper English

* Using alternative of system message container for assurance (#72)

* Using alternative of system message container for assurance in article feature

* Improve code and convert into page object

* Convert system message checks in category feature

* Convert system message container in user feature

* Repair user scenarios

* CodeStyle for the Tests (#74)

* codestyle

* Small tweeks to the RoboFile (#75)

* robo

* robo

* Changed all references to /tests as the root directory to /tests/codeception. (#78)

* Update README.md

Changed all references to /tests as the root directory to /tests/codeception.

* Update README.md

Corrected errors in the first PR

* Changed a AND into a WHEN in the file tests/codeception/acceptance/users_frontend.feature

* Update README.md (#84)

* Update README.md

Corrected two typos and inserted a warning for Firefox version above 47

* Update README.md

Corrected version numbers. 
In composer.json i found Selenium WebDriver 2.53.1
Before the current firefox version 49 there was version 45. 
With version 45.0.2 I have no problems. With version 49.0.1 I had problems.

* Update README.md

Corrections

* correction language category feature - UK to en-GB (#85)

* Update to latest selenium server standalone version (#87)

* Add a scroll to a element out of fold (#88)

* Updating the Login Step File removing hardcoded username

* Updating the feature files background step

* Updating the background step

* This should take care of the failure

* Updating the Login Step

* Trying to add a wait

* Opening the Account Details Tab

* Updating Manager Page

* Adding an Extension Manager Class

* Adding reference

* Adding Extension Step File

* Adding Extension Feature file

* Fixing another failure

* Work out of the box on Windows... (#90)

* Adding execution in Travis

* This update was a must

* Updating Robo File

* Updating Robo

* Adidng Banner Step

* Adding Feature

* Adding both the Tests

* Removing Accept Popup, not sure why this stuff is needed

* back to pavilion

* Codestyle (#95)

* Updating branch

* I have to remove it now

* Removing uninstall Extension

* Tests now run in chrome, firefox, edge and IE (#96)

* Now works on chrome, firefox, edge and IE

* update branch

* update branch

* fix mac detection and codestyle

* updating dependencies

* Update composer lock (#100)

* Remove curl check (#101)

We don't need it.

* Better wrapper method to display search tools (#102)

* Feature/add database module (#99)

* Add Database module

# Conflicts:
#	tests/codeception/acceptance.suite.dist.yml

* Add documentation

* Remove dump configuration

* Update db configuration

* Create the test database before the tests

* Revert old dependencies composer.lock (#104)

* Fix typo (#109)

* Fix typo

* Code style

* Add new line before try catch

* Add a Joomla Database Helper (#108)

* Add JoomlaDb Helper

* Fix configuration

* Update to latest joomlabrowser

* Move AcceptanceHelper to the  codeception default location for helpers (#111)

* Use default path for the AcceptanceHelper

* Use codeception defaults for helper files

* Order enabled modules alphabetical

* Remove old tests (#115)

* Remove the UserLoginCest

The UserLoginCest does not define any scenarios and is not used anywhere.

* Remove UserCest

It is not used anymore

* Composer update (#118)

Update selenium-server-standalone to version 3.0.1.2 for working on linux with chrome

* update version number in composer.json for JoomlaBrowser (#121)

* update version number in composer.json for JoomlaBrowser

* composer.lock

* Fix in the RoboFile in the env parameter

* Update composer

* Update to latest selenium server version in composer.json

Updating dependencies in composer file

* Working on clean test branch

* Working on sample tests

* bit cs

* bit cs

* Removed old steps

* revert readme (#132)

* revert readme

* readme

* Further cleanup

* Cleanup

* Cleanup

* Thank you @brianteeman

* Thank you @brianteeman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepereiradasilva @GABBAR1947 @wilsonge