[com_finder] maps view: searchtools ordering, bug corrections and some improvements #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepereiradasilva
pushed a commit
that referenced
this pull request
Oct 29, 2016
* Update gallery.xml * Update fields.php * Update internal.php * Update field.php * Update dprules.php * Update section.php * Update base.php * Update view.html.php * Update view.html.php * Update render.php * Update modal_article.php * Update sql.php * Update fields.php * Remove commented debug code * Update fields.php * #14 fixed Joomla Coding Standards and added function dock blocks code * #14 fixed Joomla Conding Standards and added function dock blocks * #14 Fixed class dock block mistake * we did not require this any more * #14 fixed Joomla Coding Standards and added function dock block in helper file at back-end * #14 Fixed only Joomla Coding Standards in FieldsHelper file * #14 removed where function, added dock blocks and fixed dock bocks coding standards errors * #14 formatted as the function doc blocks * #14 formatted as the function doc blocks * Check the active menu correct Closes #72 * Move the label field to the options tab Closes #22 * Label has it's own field and must not stay in params Regression from #22 * Backport from Digital-Peak/DPFields#32 * Fix the save and copy action Closes #37 * Store data on reload Closes #76 * Don't add always the All language to the query Closes #38 * Count the items in the category manager from com_fields Closes #61 * Corrected colspan when fields are assigned to a language * #14 fixed conflict * Don't save the All category Closes #19 * Minor language updates * Fix "Show On" tooltip's description The tooltip's description for the 'Show On' field is not showing because it is currently looking for the label. * Don't hardcode com_content.article Closes #80 * Load the types form when the data is an array * Create the links correct for the count item feature Closes #82 * Show the value from com_fields instead of the the users helper Closes #81 * Set the language correct on the fields cache Closes #47 * Removed string conversion error Closes #47 * Changed links to 3.7 * Remove legacy DPFields code * Get data from state correctly * Add joins to the com_fields in search plugin (#83) Add joins to com_fields in the content search plugin * Add new core rule core.edit.value (#75) * Add 'onFieldBeforePrepare' and 'onFieldAfterPrepare' events * Rename "Field Category" to "Field Group" Closes #91 * Add option to disable custom fields per component Closes #87 * Use select box to define the images directory Closes #97 * Truncate correctly Closes #101 * Change description field to plain textarea Closes #94 CLoses #99 * Parameters are more clear and improved comment Adapted change from joomla@32c9048 * onFieldBeforePrepare and onFieldAfterPrepare events now triggered even when custom field value is empty * Cast before access * Create params even when they are empty * Add com_fields menu entries on back end Closes #109 * Extract the context correctly Closes #112 * Add custom fields for contact * Add inline group create Closes #114 * Add simple context mapping Closes #117 * Dont assign a not existing category when a field is saved with no catid * Rename string with group and not category Closes #124 * Category strings should be named Field Groups Closes #126 * Show the fields on the blog listing Closes #108 * Installer crashes somehow Closes #132 * Merge the types set up into JFormField (#104) * Merge field types into JFormFields * Converting the rest of the fields * Merge DP Field Rendering with Joomla Form Fields * Remove the gallery scripts * Rename the interface to JFormDomfieldinterface for auto loading * Add article field as demo how a component can add fields * Removing mustache, will be replaced later with a new parser See #12 for the discussion * Fixing composer setup, reverting to 3.6.x branch * Fixing code style errors Closes #14 * Rename upgrade file to 3.7 * Strip slashes from description Related to #139 * Removing Simplepie from the database installer script Reverts 8381e46 See comments for more information * Show field group description in form Closes #139 * List field changed key to value and value to name Closes #121 * Use the first category as field filter when creating an article Closes joomla#144 * Dont show a user field on the front end Closes joomla#149 * Add always the fields path when adding the custom fields Closes joomla#150 * Added hint (placeholder) option Closes joomla#151 * Correct redirect after checkin action Closes joomla#154 * Check for group access levels when getting the fields (joomla#153) * Consider field group state Closes joomla#155 * Added missing language strings Closes #129 * JArrayHelper => ArrayHelper * reduce model method (joomla#160) * Fixing permission inheritance to edit the value of a field in the form (joomla#157) * Correct path for parameters folder when not in Joomla libraries * Type selection (joomla#162) Closes #134 * Display class attributes (joomla#143) * User home (joomla#161) * Add home parameter to media field * Correct path for paramneters folder when not in Joomla libraries * Fixing code style errors * Add new context for com_contact for contact form fields (#115) * Add new context for com_contact for contact form fields * Prepare the value on com_contact mail * Fixing travis code style errors * Use the correct variable name Closes joomla#163 * Show the all label when no category is assigned Closes joomla#165 * Don't set 0 as default hint when not present Closes joomla#166 * Fix Sniffer Whitespace errors * Fix Sniffer Whitespace errors (joomla#167) * Cleanup field model * Support fields plugins * Add gallery plugin * Moved since tag to 3.7 * Some brushup * Update controller.php * Update field.php * Update fields.php * Update controller.php * Update fields.php * Update internal.php * Update fields.php * Update fields.xml * Update field.php * Update fields.php * Update type.php * Update section.php * Update field.php * Update field.xml * Update filter_fields.xml * Update field.php * Update view.html.php * Update edit.php * Update modal_options.php * Update view.html.php * Update default.php * Update default_batch_body.php * Update modal.php * Update field.xml * Update en-GB.com_fields.sys.ini * Update en-GB.com_fields.ini * Update en-GB.plg_fields_gallery.ini * Update en-GB.plg_fields_gallery.sys.ini * Update en-GB.plg_system_fields.ini * Update en-GB.plg_system_fields.sys.ini * Update modal_article.php * Update controller.php * Update field.php * Update default_custom.php * Update captcha.php * Update editor.php * Update media.php * Update user.php * Update editor.xml * Update media.xml * Update user.xml * Update usergrouplist.xml * Update abstractlist.php * Update domfieldinterface.php * Update field.php * Update email.php * Update file.php * Update imagelist.php * Update sql.php * Update tel.php * Update textarea.php * Update url.php * Update calendar.xml * Update checkboxes.xml * Update imagelist.xml * Update integer.xml * Update list.xml * Update radio.xml * Update sql.xml * Update textarea.xml * Update url.xml * Update gallery.xml * plugin * plugin2 * typo * Change to uft8mb4 * Add new extensions to the script file * Revert merge conflict composer changes * No needed changes * Library form fields should be unaware of com_fields * Default to https * Order the tables correct * Cleanup language strings * Code errors from cleanup * Remove tags support * Add category filter * Display fielg group label when editing a group * Display all fields which are assigned to all languages correct * Don't show fields on categories as it is not ready yet * Update fields.php * Don't transofrm the category name * Correct quote name function used * Revert "Display fielg group label when editing a group" This reverts commit 1331332. * Disable tags on custom field groups * Don't include category state in filter on back end * Remove debug code * CS fix * Shortening the line length * Install SQL files for postgres * Use JDatabaseQuery * Option to show the user custom fields on the front on the contact view * Comment for item_id table column * Remove class for textareas * Fix no menu item pages giving wrong links (joomla#12020) * [plg_system_logout] Load language files only when needed (joomla#11736) * Update logout.php * cs and stuff * Update logout.php * Adding Options Button (joomla#12033) * fix paths (joomla#12032) * Fix routing for non-sef menu items with Modern Routing (joomla#12021) * [com_banners] - publishing time does not honor timezone (joomla#11978) * [com_banners ] - publishing time does not honor timezone * impress only when needed impress only when needed * CS fix cs fix * Order stylesheet attributes the same as link attributes (joomla#12052) * use joomla-projects docker * Phase out JString calls in libraries (joomla#12058) * Admin app - JString -> StringHelper (joomla#12056) * Site app & Plugins - JString -> StringHelper (joomla#12057) * New Feature, Multilanguage: Add the possibility of displaying associations in article info and in articles list. Replaces joomla#11935 (joomla#12042) * Replaces * Modifying to fit Thomas proposal * modifying fetching flags param * adding showon + some * [JAccess] Improve ACL asset preloading performance/memory consumption (joomla#12028) * improve component asset preload speed * Update user.php * Update access.php * Update access.php * Update access.php * Update access.php * not convinced yet, but revert changes in juser * make sure that components are always preloaded * only a logged users (with user id) can be root. * [com_contact] - moved the captchaEnabled var from default to view (joomla#11964) * [com_contact] - moved the captchaEnabled var out of the default.php file to the view.html.php file moved the captchaEnabled var out of the default.php file to the view.html.php file. * moved captchaEnabled to the view moved captchaEnabled to the view * missed var declarationi/initialization missed var $captchaSet declarationi/initialization * Session interaction refactoring (joomla#10905) * Allow lazy starting a session * Defer starting sessions in the installer * Defer starting session in JApplicationCms * Deprecate creating sessions in JFactory * Start restructuring session load sequence in JApplicationCms * Add JSession object to onAfterSessionStart event trigger * Override afterSessionStart for install app to not store the user * Expand the database storage object for better API * Fix session listener declaration * Restructure session bootup and when the session metadata operations run * 3.5 -> 3.6 * Remove option, out of scope * Tweak things so the behavior is closer to current API * Undefined variable * Get store name from session object * Remove this, out of scope * PHPCS fix * Deep rooted application dependencies are my absolute favorite * Move comment, doc blocks, consistent method signature * Again on the consistency, we don't like E_STRICT errors * Nevermind, confused myself with checkSession, carry on... * Until the day the unit tests no longer follow the doc block code styles... * Lost line in merge * One more merge conflict fix * This internal coupling is addressed * Fix query from merge * [com_content] - add articles ordering by votes, ratings (joomla#11225) * Add setDocumentTitle() function in JViewLegacy (joomla#11399) * setDocumentTitle() function in JViewLegacy * PHPCS * JED turned to https (joomla#12076) * JED truned to https JED truned to https Minor fixes on proper use of Joomla! * Update README.txt Same as joomla#12076 * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED turned https * JED and community turned https * JED, community and org turned https * JED and community turned https * JED and community turned https * correct/add quotename (joomla#12070) * Label: Users Options: Login name > Username (joomla#12073) The language label "Change Login Name" is not consistent with the front-end label "Username". This PR changes the language label to "Change Username" and the decription to "Allow users to change their Username when editing their profile." The front-end login screens use the label "Username" Login Component:  Login Module:  ### Testing Instructions #### Before the PR Users > Manage > [Options] > [User Options] The last entry is "Change Login Name" + hover description "Allow users to change their Login name when editing their profile."  #### After the PR Users > Manage > [Options] > [User Options] The last entry is "Change Username" + hover description "Allow users to change their Username when editing their profile."  * Update .travis.yml (joomla#12079) * Add vote order check * [a11y] Protostar back to top (joomla#12446) * [a11y] Protostar - back to top link * Oops Andre was right * add anchor for non-js enabled browsers * Added missing com_fields component from last merge
andrepereiradasilva
pushed a commit
that referenced
this pull request
Jun 3, 2017
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
andrepereiradasilva
pushed a commit
that referenced
this pull request
Jun 22, 2017
…ts (joomla#16743) * System tests with codeception 2.2 * System tests with codeception 2.2 * System tests with codeception 2.2 * System tests with codeception 2.2 * Instructions for testing * Instructions for testing * Remove useless header * [tests] new convention for locating elements Adds Gherkin Pages and Step Objects as sample of useage * Update Codeception to 2.2.1 * Writing new composer.lock file for update * Adding users.feature scenarios using gherkin * Adding content.feature scenarios using gherkin * Adding users.feature file * Adding scenarios for access level and user group * Adding Assert module for assertion * Implementing Pageobject * Passing $title and $content as a argument * Implement step and page object in users.feature file * Add missing pages * New approach to manage suite configuration * Fix the issue_#29 and issue_#31 * Fix the issue_#30 * Fix the issue #37 * Remove the commented code * Every page object have the $url property * Update Codeception to version 2.2.2 * Create a constant for waiting times * Adding project information in README.md * update readme * Update README.md for TIMEOUT * Checking if TIMEOUT is not already set Pull Request for Issue #45 . Update a constant for waiting times It contains fix related to #47 * Using contants for timeouts * Improvement in frontend feature * improve the scenario * correct typo and improvement * Implement user frontend scenarios * Updated travis to only run system tests and no unit tests * add how to create snippets * category Scenario for issue #35 * Fix missing call to Step object * Move administrator login to the current page object pattern * Move administrator login to the current page object pattern * Remove Given Joomla CMS is installed * Update composer * Fix LoginPage * Fix missing call to step object * Use genering url name for page variable * Simplify users manager table xpath * Fix typo error * Allow robo to run individual .feature tests (#58) * Allow robo tu run individual .feature tests * Improve running individuals tests documentation * Implement the categories scenario * slove xpath issue and implement frontend scenario * Handle waiting for iframe and menu edit view to save menu item * Updating selenium to 2.53.1 * Updated travis integration for running tests (#60) * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Updated travis integration for running tests * Working on Travis * Working on Travis * Working on Travis * Working on Travis * Adding docblocks and code style improvements * Adding phpdoc header and code style improvement in acceptance tester * [dockblock] Adding in Admin page object * [dockblock] Adding dockblock in content manager page object * [code style] Improve name of variable * [dockblock] Adding dockblock in control panel page object * [dockblock] Using AcceptanceTester.Page as a subpackage * [dockblock] Adding dockblock in login page object * [dockblock] Adding docblock in user acl page object * [dockblock] Adding dockblock in user group page object * [dockblock] Adding dockblock in user manager page object * [code style] Adding code style improvement in acceptance tester class * [docblock] Adding docblock in acceptance helper class * [docblock] Adding docblock in functional and unit testing class * [docblock] Adding docblocks and code style improvements in site page objects * [code style] Adding docblock and code style improvements * [code style] Adding code style improvement in acceptance tester * [docblock] Adding docblock in content step object * [docblock] Adding docblock and code style improvement in category step object * Adding category feature execution using Robo * [docblock] Adding docblock and code style improvement for category and menu page objects * Rearrange tab based on latest joomla * [docblock] Adding docblock and code style improvement in login and user step objects * [docblock] Adding docblock and code style improvement in login and user step objects * [docblock] Adding docblock and code style improvement in user frontend step objects * Remove extra blank lines * Remove comments from robo * Using __DEPLOY_VERSION__ instead of static 3.7 * Forcing 127.0.0.1 for /etc/hosts in travis * [code optimize] code optimization and remove duplicate codes (#65) * [code optimize] Combine save method for category and content * Using page object dynamically * Revert "[code optimize] Combine save method for category and content" This reverts commit 82682c5d57a14707c191736a57f22011c2fd54be. * Usign dynamic wait for test string * [duplicate] Handle duplicate code for user form * Using common annotation for create new user * [duplicate] Using common annotation for login in frontend scenarios * [duplicate] Using page object method to have user with username * [duplicate] Using page object method to have category with given title * [duplicate] Using page object method to have article with given title * [optimize] Reusing code by using oop concept * Resolve error in creating instance * Reuse fill article form code * Create Admin step * Using common method to search and select * Using common method for see system message * Using common method for search * Remove duplicate code * Remove duplicate code for delete and empty * Using property from parent class * Using Admin step as a parent class * Cleanup acceptance tester * Using generic page object properties * Updating travis and Robo to the final structure * Updating and moving codeception-build script * Updating and moving codeception-build script * Updating and moving codeception-build script * Updating and moving codeception-build script * Updating and moving codeception-build script * Updating and moving codeception-build script * Updating and moving codeception-build script * change the tests with generic name (#68) * change the tests with generic name * Rename test user1 to User One * Rename the email and login name * Remove acceptance.suite.yml file from git list (#70) * Remove acceptance.suite.yml file from git list * Remove unnecessory _generated folder * Fix issue #57 Update frontend_user tests (#61) * Fix issue_#57 Update frontend_user tests as per commented in PR #51 * [codestyle] Adding docblock and code style improvement in Robo and user frontend * Verify in backend that user is created * Fix scenario in user_frontend.feature to proper English * Using alternative of system message container for assurance (#72) * Using alternative of system message container for assurance in article feature * Improve code and convert into page object * Convert system message checks in category feature * Convert system message container in user feature * Repair user scenarios * CodeStyle for the Tests (#74) * codestyle * Small tweeks to the RoboFile (#75) * robo * robo * Changed all references to /tests as the root directory to /tests/codeception. (#78) * Update README.md Changed all references to /tests as the root directory to /tests/codeception. * Update README.md Corrected errors in the first PR * Changed a AND into a WHEN in the file tests/codeception/acceptance/users_frontend.feature * Update README.md (#84) * Update README.md Corrected two typos and inserted a warning for Firefox version above 47 * Update README.md Corrected version numbers. In composer.json i found Selenium WebDriver 2.53.1 Before the current firefox version 49 there was version 45. With version 45.0.2 I have no problems. With version 49.0.1 I had problems. * Update README.md Corrections * correction language category feature - UK to en-GB (#85) * Update to latest selenium server standalone version (#87) * Add a scroll to a element out of fold (#88) * Updating the Login Step File removing hardcoded username * Updating the feature files background step * Updating the background step * This should take care of the failure * Updating the Login Step * Trying to add a wait * Opening the Account Details Tab * Updating Manager Page * Adding an Extension Manager Class * Adding reference * Adding Extension Step File * Adding Extension Feature file * Fixing another failure * Work out of the box on Windows... (#90) * Adding execution in Travis * This update was a must * Updating Robo File * Updating Robo * Adidng Banner Step * Adding Feature * Adding both the Tests * Removing Accept Popup, not sure why this stuff is needed * back to pavilion * Codestyle (#95) * Updating branch * I have to remove it now * Removing uninstall Extension * Tests now run in chrome, firefox, edge and IE (#96) * Now works on chrome, firefox, edge and IE * update branch * update branch * fix mac detection and codestyle * updating dependencies * Update composer lock (#100) * Remove curl check (#101) We don't need it. * Better wrapper method to display search tools (#102) * Feature/add database module (#99) * Add Database module # Conflicts: # tests/codeception/acceptance.suite.dist.yml * Add documentation * Remove dump configuration * Update db configuration * Create the test database before the tests * Revert old dependencies composer.lock (#104) * Fix typo (#109) * Fix typo * Code style * Add new line before try catch * Add a Joomla Database Helper (#108) * Add JoomlaDb Helper * Fix configuration * Update to latest joomlabrowser * Move AcceptanceHelper to the codeception default location for helpers (#111) * Use default path for the AcceptanceHelper * Use codeception defaults for helper files * Order enabled modules alphabetical * Remove old tests (#115) * Remove the UserLoginCest The UserLoginCest does not define any scenarios and is not used anywhere. * Remove UserCest It is not used anymore * Composer update (#118) Update selenium-server-standalone to version 3.0.1.2 for working on linux with chrome * update version number in composer.json for JoomlaBrowser (#121) * update version number in composer.json for JoomlaBrowser * composer.lock * Fix in the RoboFile in the env parameter * Update composer * Update to latest selenium server version in composer.json Updating dependencies in composer file * Working on clean test branch * Working on sample tests * bit cs * bit cs * Removed old steps * revert readme (#132) * revert readme * readme * Further cleanup * Cleanup * Cleanup * Thank you @brianteeman * Thank you @brianteeman
andrepereiradasilva
pushed a commit
that referenced
this pull request
Dec 24, 2018
* Begin the capabilities reporting screen, list some core capabilities * Add the plugin reporting hook to capability collection * Add notes about hashed cookie name * Import installer plugin group to capabilities to be able to include install from web without needing a second plugin * Add info about core communications to joomla.org due to conflicting opinions/guidance on handling of IP addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions