Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In sequence of #xxxx, this PR does some improvements to searchtools with the goal of removing all backend searchtools layout overrides. Also does other improvements:
noresults
to the search field in the filter fields xml. This attribute contains the language string of the no results message of th searchtoolslayout
to the selector field in the filter fields xml. This attribute contains the layout where the field should be rendered (no attribute for all). This is useful for views that have 2 layouts. example modules has default layout and modal layout.filtermode
to the selector field in the filter fields xml. This attribute has only one valueselector
. This is used to identify which field is the selector.As PoC i implemented, in this PR, the changes in all views that currently have a "selector":
Also, as PoC implemented it in:
Testing Instructions
Observations
After, and if, this is merged i will change all the other views to use this new searchtools model, by replacing something like this:
By this (moving also the no results message to the xml file
noresults="COM_CHECKIN_NO_ITEMS"
)