Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better searchtools #40

Closed
wants to merge 8 commits into from
Closed

Conversation

andrepereiradasilva
Copy link
Owner

@andrepereiradasilva andrepereiradasilva commented Apr 25, 2016

Summary of Changes

In sequence of #xxxx, this PR does some improvements to searchtools with the goal of removing all backend searchtools layout overrides. Also does other improvements:

  1. Adds a attribute noresults to the search field in the filter fields xml. This attribute contains the language string of the no results message of th searchtools
  2. Adds a attribute layout to the selector field in the filter fields xml. This attribute contains the layout where the field should be rendered (no attribute for all). This is useful for views that have 2 layouts. example modules has default layout and modal layout.
  3. Adds a attribute filtermode to the selector field in the filter fields xml. This attribute has only one value selector. This is used to identify which field is the selector.
  4. Now it can autodetect if the filters button "Search Tools" should exist or not.
  5. Removed all the, now not needed, searchtools backend layout overrides.

As PoC i implemented, in this PR, the changes in all views that currently have a "selector":

  • com_menus items view: selector menutype
  • com_cache cache view: selector client_id
  • com_modules modules view (default and modal layout): selector client_id
  • com_languages installed view: selector client_id

image

Also, as PoC implemented it in:

  • com_checkin checkin view
  • com_modules modules view (frontend popup)

image

Testing Instructions

  1. Test the searchtools in the several views changed in this PR. You'll notice that in this views the no results message is now blue. Test if they work properly.
  2. Test some of the unchanged views to test if they still work properly.

Observations

After, and if, this is merged i will change all the other views to use this new searchtools model, by replacing something like this:

<?php echo JLayoutHelper::render('joomla.searchtools.default', array('view' => $this, 'options' => array('filterButton' => false))); ?>
<div class="clearfix"></div>
<?php if (empty($this->items)) : ?>
    <div class="alert alert-no-items">
        <?php echo JText::_('COM_CHECKIN_NO_ITEMS'); ?>
    </div>

By this (moving also the no results message to the xml file noresults="COM_CHECKIN_NO_ITEMS")

<?php echo JLayoutHelper::render('joomla.searchtools.default', array('view' => $this)); ?>

andrepereiradasilva pushed a commit that referenced this pull request Jun 3, 2017
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
andrepereiradasilva pushed a commit that referenced this pull request Dec 24, 2018
andrepereiradasilva pushed a commit that referenced this pull request Dec 24, 2018
* move to it own field

* move to it own field

* fix since

* $modalHTML

* init html and drone

* drone ...

* Move modal to field renderer (#40)

* Move modal to field renderer

* Fix var type

* Fix wrong variable

* __DEPLOY_VERSION__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant