Joomla! Update: reinstall Joomla! and Update & Install features | seccond try #9612

zero-24 · 2016-03-26T19:15:52Z

Pull Request for Issue #9469.

Summary of Changes

Added features to Joomla! Update:

Reinstall. If you're already on the latest version you are given the option to re-download the full update package and install it on top of your site. Useful if someone has made core hacks and you want to undo them.
Upload & Update. Now that we have removed the ability to install Joomla! as an extension to itself the users with no FTP access and/or no outbound server Internet access (e.g. behind a corporate DMZ firewall) are unable to update. We now have the option to upload the update package. Since this is dangerous and could potentially be abused you need to re-enter your login information after the upload and before the uploaded package is installed. Failure to comply removes the uploaded file.

Testing Instructions

First test

install 3.4.8 from https://github.com/joomla/joomla-cms/releases/tag/3.4.8
go to your database and run this command (it changes the update server of the update component to my own hosted version)

UPDATE  `#__update_sites` SET  `location` =  'http://www.jah-tz.de/downloads/extensions/dev/com_joomlaupdate.xml' WHERE  `location` = 'http://update.joomla.org/core/extensions/com_joomlaupdate.xml';

go to Extensions -> Update
install the com_joomlaupdate Update
Go to com_joomlaupdate
notice the layout of the new Update
switch to the Tab "Upload & Install"
download: https://github.com/joomla/joomla-cms/releases/download/3.5.0/Joomla_3.5.0-Stable-Update_Package.zip
Upload the 3.5.0 update package.
watch the progress bar
see that you updated to 3.5.0 stable now.

Note

Please notice that as the 3.5.0 stable package don't include the changes here the new overview is gone for now. But if you follow the seccond test it come back 😄

seccond test

install 3.5.0 stable or staging (you can also use the result of the first test)
install com_patchtester
apply this fix of com_patchtester: Added non production files to the exclude array joomla-extensions/patchtester#133
apply this patch
go to com_joomlaupdate
notice the new layout
try the reinstall feature
try the upload and install freature

For the code reviewer

The changes between the code by @nikosdion and me can be found here: https://github.com/nikosdion/joomla-cms/compare/feature/joomlaupdate-reinstall...zero-24:feature/joomlaupdate-reinstall

Some other things

The needed update xml for com_joomlaupdate can be found here: joomla/update.joomla.org#6

The com_joomlaupdate package can be found here (it is the same as on my server for updating):
http://www.jah-tz.de/downloads/download.php?file=com_joomlaupdate.zip&folder=extensions/dev/

Limitations of using the com_joomlaupdate standalone. (edit)

You can't use the reinstall feature as the standalone package don't update the updater lib file please see: #9612 (comment)

Thanks

Thanks goes to @nikosdion @wilsonge and @mbabker and com_patchtester (as there we can find how we should create a update packages)

Add type hints to Joomla! Update's controller

Refactored JUpdater, made it possible to record the current version of an extension into the #__updates table

Model and view template changes

…pdate-reinstall

…te-reinstall

Keeping it it simple and clean

When JUpdater::findUpdates has four (or more) parameters we can use the reinstall support by passing true in the fourth parameter (includeCurrent). Otherwise we have to call findUpdates with three parameters which only gives us available updates. This is necessary since Joomla! Update can run under older Joomla! 3.x releases, most notably 3.4, which lack the reinstall support.

While the FTP credentials were applied, the file write method was ignored. That explains why a buch of users reported that Joomla! Update didn't work for them. Since the included restore.php supports the Hybrid file write mode (direct file writes where possible, FTP only when the file is unwriteable) I added that option as well.

* Missing token * Typo in JoomlaupdateControllerUpdate::captive() * We must store the base name, not the full path to the captive file

Minor Fixes

…'s advice

wilsonge · 2016-04-07T19:19:05Z

The "standalone" component is exactly what we ship in the CMS right now - you can generate the standalone package by running this script https://github.com/joomla/joomla-cms/blob/staging/build.xml#L142 - I haven't had time to do it myself yet so i can't link you to a package

brianteeman · 2016-04-07T20:44:26Z

Whoever said it wont be merged. This is RTC with a milestone of 3.5.2

wilsonge · 2016-04-07T21:00:53Z

This as is is going to be merged. All we are going to do is also produce a zip of exactly this that people can upload onto older Joomla sites (especially people still stuck on 3.4.8)

Webdongle · 2016-04-07T21:11:23Z

Thanks @brianteeman @wilsonge

I obviously misunderstood.... I thought the stand alone zip was instead of having it in the core.

brianteeman · 2016-04-07T21:22:00Z

No it will be in core but by making it something that can be installed it
can be installed in earlier releases of joomla but more importantly it
allows for the situation where we need to change the updater BEFORE someone
can update their joomla release.

On 7 April 2016 at 22:11, Kevin Griffiths [email protected] wrote:

Thanks @brianteeman https://github.com/brianteeman @wilsonge
https://github.com/wilsonge

I obviously misunderstood.... I thought the stand alone zip was instead of
having it in the core.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9612 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

mbabker · 2016-04-07T21:23:00Z

For reference we made it possible to do this after 3.3.6 needed to be released because of an issue introduced into the restore.php script. The mechanism has never been needed though.

rdeutz · 2016-04-12T19:58:04Z

@zero-24 could you have a look at the merge conflicts, danke

joomla-cms-bot · 2016-04-12T20:11:13Z

This PR has received new commits.

CC: @richard67, @Webdongle

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9612.}

zero-24 · 2016-04-12T20:11:23Z

Fixed @rdeutz but please double check with @wilsonge about this PR.

richard67 · 2016-04-12T20:15:12Z

I will be able to test again tomorrow if still necessary then.

andrepereiradasilva · 2016-04-12T21:36:18Z

administrator/language/en-GB/en-GB.com_joomlaupdate.ini

-COM_JOOMLAUPDATE_VIEW_DEFAULT_FTP_PASSWORD="FTP password"
-COM_JOOMLAUPDATE_VIEW_DEFAULT_FTP_PORT="FTP port"
-COM_JOOMLAUPDATE_VIEW_DEFAULT_FTP_USERNAME="FTP username"
+CCOM_JOOMLAUPDATE_VIEW_DEFAULT_FTP_DIRECTORY="FTP Root"


@zero-24 see zero-24#3

remove CCOM and replace with COM

joomla-cms-bot · 2016-04-13T05:13:58Z

This PR has received new commits.

CC: @richard67, @Webdongle

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9612.}

zero-24 · 2016-04-13T05:16:38Z

Sorry guys i have just fixed it by merging brian's PR thanks @andrepereiradasilva & @brianteeman

Nicholas K. Dionysopoulos and others added 30 commits March 11, 2016 10:36

Joomla! Update: Reinstall current version

13416a8

Add type hints to Joomla! Update's controller

Joomla! Update: Reinstall current version

8880ed9

Refactored JUpdater, made it possible to record the current version of an extension into the #__updates table

Joomla! Update: Reinstall current version

a8d1488

Model and view template changes

Merge remote-tracking branch 'nikosdion/staging' into feature/joomlau…

6701709

…pdate-reinstall

Merge remote-tracking branch 'joomla/staging' into feature/joomlaupda…

8278b6e

…te-reinstall

Oops, typo

128eeb9

Bump Joomla! Update version

e4e6e62

Move alternative panels into separate view template layouts

133d315

Keeping it it simple and clean

Upload form in a tab

a6dd02c

Typo

91bee90

Upload to temporary file

0e3e7fa

Captive login validation

c9f459c

Final step to install from file

7cd1954

Bug fixes

2137111

* Missing token * Typo in JoomlaupdateControllerUpdate::captive() * We must store the base name, not the full path to the captive file

Code style fixes

9106bdf

Add back weblinks file

27a8491

Merge pull request #1 from wilsonge/joomlaupdate

18e504f

Minor Fixes

Removing the bang from "Joomla!" in the language files per @brianteeman…

e559c76

…'s advice

Misplaced token check

61bd494

Not enough coffee

387cec6

Profoundly crap code to make our asinine PHP Code Sniffer rules happy

71c9469

bump version number and some CS

a798b11

Update default.php

e8ac62c

version numbers

a7209c5

some CS

6eb64bf

CS

4b0e62f

CS

78b6110

set login center and some cs

fd8e576

This was referenced Apr 7, 2016

en-GB language pack package correction (fix inconsistency) andrepereiradasilva/joomla-cms#29

Closed

Solves inconsistency with en-GB language package #9835

Merged

Undefined property: JUpdate::$downloadurl when trying to upgrade from 3.4.8 - 3.51 #9866

Closed

fix merge conflicts

1718d29

andrepereiradasilva reviewed Apr 12, 2016
View reviewed changes

brianteeman and others added 2 commits April 12, 2016 22:41

remove CCOM and replace with COM

6264d68

Merge pull request #3 from brianteeman/patch-2

bdee865

remove CCOM and replace with COM

rdeutz mentioned this pull request Apr 13, 2016

Use JHttpFactory as transport mechanism #8645

Merged

rdeutz merged commit c05e6b1 into joomla:staging Apr 13, 2016

zero-24 deleted the feature/joomlaupdate-reinstall branch April 13, 2016 12:38

rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016

brianteeman added Feature and removed RTC This Pull Request is Ready To Commit labels May 9, 2016

andrepereiradasilva mentioned this pull request Jun 5, 2017

[3.7] Core components loose menu links in Control Panel after manual update #16454

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Joomla! Update: reinstall Joomla! and Update & Install features | seccond try #9612

Joomla! Update: reinstall Joomla! and Update & Install features | seccond try #9612

zero-24 commented Mar 26, 2016

wilsonge commented Apr 7, 2016

brianteeman commented Apr 7, 2016

wilsonge commented Apr 7, 2016

Webdongle commented Apr 7, 2016

brianteeman commented Apr 7, 2016

mbabker commented Apr 7, 2016

rdeutz commented Apr 12, 2016

joomla-cms-bot commented Apr 12, 2016

zero-24 commented Apr 12, 2016

richard67 commented Apr 12, 2016

andrepereiradasilva Apr 12, 2016

brianteeman Apr 12, 2016

joomla-cms-bot commented Apr 13, 2016

zero-24 commented Apr 13, 2016

Joomla! Update: reinstall Joomla! and Update & Install features | seccond try #9612

Joomla! Update: reinstall Joomla! and Update & Install features | seccond try #9612

Conversation

zero-24 commented Mar 26, 2016

Summary of Changes

Testing Instructions

First test

Note

seccond test

For the code reviewer

Some other things

Limitations of using the com_joomlaupdate standalone. (edit)

Thanks

wilsonge commented Apr 7, 2016

brianteeman commented Apr 7, 2016

wilsonge commented Apr 7, 2016

Webdongle commented Apr 7, 2016

brianteeman commented Apr 7, 2016

mbabker commented Apr 7, 2016

rdeutz commented Apr 12, 2016

joomla-cms-bot commented Apr 12, 2016

zero-24 commented Apr 12, 2016

richard67 commented Apr 12, 2016

andrepereiradasilva Apr 12, 2016

Choose a reason for hiding this comment

brianteeman Apr 12, 2016

Choose a reason for hiding this comment

joomla-cms-bot commented Apr 13, 2016

zero-24 commented Apr 13, 2016