Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#746 #747

Closed
wants to merge 112 commits into from
Closed

Issue/#746 #747

wants to merge 112 commits into from

Conversation

darylhedley
Copy link
Contributor

Fixes #746

darylhedley and others added 30 commits April 10, 2015 16:24
Also stringifies options object so it can work with nodejs v0.12

fixes #630
desc: update application.js to allow the use of express middleware by plugins
desc: fixed indentation.
desc: frontend plugins can have their own language files /lang/en.json currently only supported. Exisiting users will need to install grunt-merge-json: npm install grunt-merge-json --save-dev.
- Adds validate:false override as we don’t use backbone.model.validate
- Fixes getting and setting of assets
- Adds Origin.scaffold.getCurrentForm for all your form goodiness
desc:highlight search box when used and matching portions of project titles.
desc: replaced asyn with foreach and added logging on exception error
desc: removed redunant var output and fixed indent
description: remove courseassets from mongoDB collection when asset is disassociated from field.
desc:removed typo
The hashed filename is unique so this gets around problems with spaces in
the filenames, special characters, etc.
Issue/#649 part2 Allow assets to be removed from mongoDB collection when removed from course
desc: change better regulate middleware introduced by plugins
- Also brings in Finbars changes
Corrected caching of the single page app
Switch editor to cdn -- development branch update
This will generate a warning if not v0.10.33.
- Adds ability to link external assets
- Gives a more detailed err output when pressing preview and it runs an
external grunt task
- Matches model data to hidden input value
darylhedley and others added 27 commits June 2, 2015 14:37
also fixes issue around error callback not actually being an error
Changes the way the modal window overlays
Fix to old asset not being able to remove themselves
- Removed 'colors' library in favour of 'chalk'
- Added missing error logging -- the install process would hang if the mongod service was not running
- Minor string changes
This was using the old 'colors' library and missed from the previous commit.
A hangover from the 'colors' library.
This will save on API calls to return thumbnails which don't exist and present a consistent UI to the user.
Separate the setting of assetType and metadata
The en.json files is now the 'compiled' version.  I've renamed the original file to en-application.json and updated the Gruntfile and .gitignore.

This way, running a build won't flag the en.json file as a modified file, which was happening previously since the merge task was introduced.
This patch is to handle circumstances where an uploaded zip file has an unexpected folder structure.
Added logging and error for when plugin structure is incorrect
Tidied up the package.json to re-work devDependencies and update the README accordingly.

For the majority of end-users this will reduce the need to install PhantomJS, which had sometimes caused issues.
- Corrected contributors list
- Updated version number
- Corrected dependencies
Conflicts:
	plugins/content/bower/index.js
Fixes reference to files[0] to the actual folder name
@darylhedley darylhedley closed this Jul 9, 2015
@darylhedley darylhedley deleted the issue/#746 branch July 9, 2015 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants