Version checking on bootstrap #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto version-checking-on-bootstrap Conflicts: upgrade.js
| @@ -26,6 +26,9 @@ var EventEmitter = require('events').EventEmitter, | |||
| Mailer = require('./mailer').Mailer, | |||
| configuration = require('./configuration'); | |||
|
|
|||
| var request = require('request'); | |||
| var async = require('async'); | |||
| var chalk = require('chalk'); | |||
There was a problem hiding this comment.
The install.js uses 'colors' still. Chalk looks better. Can you update the install.js to swap out colors usage for chalk, and remove colors from the dependencies too?
pretty please :)
There was a problem hiding this comment.
I've removed 'colors'.
- Removed 'colors' library in favour of 'chalk' - Added missing error logging -- the install process would hang if the mongod service was not running - Minor string changes
|
+1 |
This was using the old 'colors' library and missed from the previous commit.
A hangover from the 'colors' library.
|
+1 |
brian-learningpool
added a commit
that referenced
this pull request
Jul 1, 2015
Version checking on bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds upgrade script to the authoring tool