Removes sidebar update class #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also stringifies options object so it can work with nodejs v0.12 fixes #630
| @@ -47,6 +47,7 @@ function initialize () { | |||
| var options = _.keys(req.body).length | |||
| ? req.body | |||
| : req.query; | |||
| var options = JSON.stringify(options); | |||
There was a problem hiding this comment.
you could remove the var. Already declared in line above var options = _.keys(req.body).length.
+1 apart from that
There was a problem hiding this comment.
@darylhedley - actually, can you remove this bit? I think this is related to the issues with node v0.12, but we're only supporting 0.10.33 at the moment, and this workaround needs a closer look.
|
+1 |
1 similar comment
|
+1 |
brian-learningpool
added a commit
that referenced
this pull request
Apr 16, 2015
Removes sidebar update class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stringifies options object so it can work with nodejs v0.12
fixes #630