Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we want to allow all asset types in AssetManagementModalView? #711

Closed
taylortom opened this issue May 28, 2015 · 1 comment
Closed

Do we want to allow all asset types in AssetManagementModalView? #711

taylortom opened this issue May 28, 2015 · 1 comment
Labels
T: question Intended to open a discussion

Comments

@taylortom
Copy link
Member

Currently, only 'other' assets are displayed. I can imagine it being useful to also link to images etc. here.

Any thoughts?
@taylortom taylortom added the T: question Intended to open a discussion label May 28, 2015
@darylhedley
Copy link
Contributor

I think the scaffoldAssetView should really handle this. So if you want all types of assets (mainly thinking about resources here) you should be able to put Asset instead of Asset:other as the type in the schema file. Will add this in

@darylhedley darylhedley self-assigned this Jun 9, 2015
darylhedley added a commit that referenced this issue Jun 9, 2015
@darylhedley
Fixes #711
5cd333f
@darylhedley darylhedley mentioned this issue Jun 9, 2015
Merged
brian-learningpool added a commit that referenced this issue Jun 11, 2015
@brian-learningpool
Merge pull request #724 from adaptlearning/issue/#711
08e937c 
Fixes #711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: question Intended to open a discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@taylortom @brian-learningpool @darylhedley