Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.60.x #6546

Merged
merged 22 commits into from
Nov 27, 2024
Merged

Release/v0.60.x #6546

merged 22 commits into from
Nov 27, 2024

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Nov 27, 2024

Summary

  • release SigNoz v0.60.0
  • bump up SigNoz OtelCollector v0.111.13

Important

Update SigNoz to v0.60.0 with new trace schema support, enhanced telemetry, and infrastructure monitoring features.

  • Version Updates:
    • Update SigNoz to v0.60.0 and OtelCollector to v0.111.13 in docker-compose.yaml and other Docker setup files.
  • API and Backend Changes:
    • Add UseTraceNewSchema flag in api.go, server.go, and reader.go to support new trace schema.
    • Modify SearchTraces in traces.go to handle new trace API.
    • Update GetServices and GetTopOperations in reader.go to support new schema.
  • Telemetry Enhancements:
    • Add telemetry events for trace queries in telemetry.go.
    • Track dashboards and alerts with trace ClickHouse queries.
  • Frontend Enhancements:
    • Add infrastructure monitoring features in AppRoutes and InfraMonitoring.json.
    • Implement new components for host metrics and logs in HostMetricsDetail.
  • Miscellaneous:
    • Fix logging and error handling in logparsingpipeline/preview.go.
    • Update ValidateAndCastValue in format.go to handle string arrays.

This description was created by Ellipsis for 7cd8442. It will automatically update as commits are pushed.

nityanandagohain and others added 22 commits November 20, 2024 22:51
* feat: update clickhouse reader to support new trace schema

* fix: minor fixes

* fix: address comments

* fix: add changes to overview function

* fix: add changes to overview function

* fix: use hardcoded true

* fix: address comments
* feat: added the host list view and filters (#6210)

* feat: added the host list view and filters

* feat: removed group by filter and added autocomplete for where clause

* feat: updated the table view and added the pagination

* feat: pass updated filters to api to get filtered data in the list

* feat: added global time range and order by for cpu,memory,iowait,load

* feat: added order by and color codes for cpu and memory usage progress bar

* refactor: removed inline styles

* Host lists improvement (#6366)

* style: added new style changes for date time selection in host lists view

* style: added padding to date time selector

* style: removed unnecessary styles for host tabs

* style: removed unused css

* feat: added the host detail view (#6267)

* Host containers (#6297)

* feat: added the host detail view

* feat: completed containers and processes details view

* Show host metrics panels in metrics tab. (#6306)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* style: added top and bottom margin to containers and processes tab

* Metrics time selection (#6360)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* feat: added logs and traces tab in host metrics detail view

* chore: removed console statements

* feat: added DateTimeSelection component in metrics tab

* style: added top and bottom margin to containers and processes tab

* style: removed inline styles

* feat: added logs and traces tab in host metrics detail view (#6359)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* feat: added logs and traces tab in host metrics detail view

* chore: removed console statements

* feat: added filters and time selection in traces tab

* fix: resolved metrics,logs and traces tab issues

* feat: added navigation for logs and traces to respective explorer pages

* fix: added the code for logs tab and navigation to respective explorer page

* fix: added fixes for date time selection custom issue

* style: added styles for light mode

* refactor: removed unused code and added comments

* refactor: added new code for host metric attribute keys

* feat: reset query data once we are on infra monitoring page

* chore: remove optional parameter from get attributes and groupby interfaces

* feat: update ui as per the designs

* fix: logs list, time select and other ui issues

* feat: update title for infra monitoring page

* feat: update copies

* feat: update styles for light mode

* fix: reset page size on filter, open explorers in new tab, enable horizontal scroll

* feat: traces tab updates

* feat: move infra monitoring behind ff

* fix: remove sorting from host listing page

---------

Co-authored-by: Yunus M <[email protected]>

* chore: fix lint errors

---------

Co-authored-by: rahulkeswani101 <[email protected]>
* feat: tt api for new trace tables

* fix: remove print and use correct context

* fix: update var name
* feat: trace v4 inital commit

* fix: add remaining files

* fix: integrate with querier

* fix: get trace by id api updated

* fix: add servicename resource filter

* fix: tests

* fix: use correct prepQUery

* fix: services page

* fix: minor fixes to use the new table in api's and querier

* fix: add support for window based pagination

* feat: support for faster trace detail

* fix: searchTraces

* fix: attribute enrichment updated and issue in group by

* fix: issues in group by

* fix: enrichment using alias

* fix: test file added

* fix: tests

* fix: group by with filters

* fix: add subquery

* fix: trigger builde

* fix: update pagination logic and few ch column names

* fix: update qb

* fix: add tests

* feat: minor fixes

* fix: update pagination logic

* fix: update pagination logic

* fix: remove utils

* fix: remove unwanted API's

* fix: attribute and attribute values v2

* fix: autocomplete api's updated

* fix: tests fixed

* feat: minor fixes

* fix: update telemetry functions

* fix: dont use alias, use proper col names

* fix: move models to it's own file

* fix: minor fixes

* fix: address comments

* fix: add to serviceoverview function

* fix: add changes to overview function

* fix: address comments

* fix: remove printlines

---------

Co-authored-by: Srikanth Chekuri <[email protected]>
* fix: pie chart should not have padding between adjacent items

* fix: remove the labels which do not have any data
* fix: add v2 for getServices and GetTopOperations

* fix: add comments

* fix: update logic for filters

---------

Co-authored-by: Srikanth Chekuri <[email protected]>
…6517)

* fix: add settings to allow distributed_product_mode for trace panel

* fix: tests fixed

* fix: add 10gb memory limit

---------

Co-authored-by: Srikanth Chekuri <[email protected]>
* chore: move all the usages of license v2 to license v3

* chore: added log lines for debugging
* chore: qs: logs pipeline preview: use collectorsimulator from signoz-otel-collector

* chore: qs: remove collectorsimulator: located in signoz-otel-collector now
@prashant-shahi prashant-shahi requested a review from a team as a code owner November 27, 2024 09:46
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 7cd8442 in 3 minutes and 39 seconds

More details
  • Looked at 9592 lines of code in 135 files
  • Skipped 3 files when reviewing.
  • Skipped posting 8 drafted comments based on config settings.
1. pkg/query-service/app/clickhouseReader/reader.go:1058
  • Draft comment:
    Check for errors returned by r.db.QueryRow to ensure any issues are handled appropriately.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. pkg/query-service/app/inframetrics/hosts.go:373
  • Draft comment:
    Check for errors returned by GetCountOfThings to ensure proper error handling.
  • Reason this comment was not posted:
    Comment did not seem useful.
3. pkg/query-service/app/clickhouseReader/reader.go:708
  • Draft comment:
    Consider using zap.L().Warn instead of zap.L().Error for non-critical issues to avoid alarming logs for expected conditions.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code is using zap.L().Error to log errors, but it should use zap.L().Warn for non-critical issues. This is a common pattern in the codebase, so it should be addressed in multiple places.
4. frontend/src/components/HostMetricsDetail/HostMetricsDetail.styles.scss:1
  • Draft comment:
    Avoid using inline styles in React components. Use external stylesheets or styled components instead. This is applicable in HostMetricsDetail.styles.scss and other similar files.
  • Reason this comment was not posted:
    Comment was on unchanged code.
5. frontend/src/container/HostMetricsLoading/HostMetricsLoading.tsx:14
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead.
  • Reason this comment was not posted:
    Marked as duplicate.
6. frontend/src/container/HostMetricsLoading/HostMetricsLoading.tsx:15
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead.
  • Reason this comment was not posted:
    Marked as duplicate.
7. frontend/src/components/HostMetricsDetail/Containers/Containers.tsx:18
  • Draft comment:
    Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This is also applicable in Processes.tsx.
  • Reason this comment was not posted:
    Marked as duplicate.
8. frontend/src/components/HostMetricsDetail/HostMetricsDetails.tsx:481
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_bgvtEcaa5gjyusvB


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prashant-shahi prashant-shahi merged commit a320a16 into main Nov 27, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants