Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/qs use collector simulator from signoz otel collector #6539

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Nov 26, 2024

Summary

Remove collectorsimulator in query service and use collectorsimulator from signoz-otel-collector for powering logs pipeline previews.

The collectorsimulator was moved to signoz-otel-collector to make it easier to test the new pipeline processor and to make it easier to update the simulator when signoz-otel-collector upgrades upstream version - SigNoz/signoz-otel-collector#446

Related Issues / PR's

contributes to logs pipelines cleanups: #3791


Important

Replace internal collectorsimulator with signoz-otel-collector version in query-service and remove redundant code.

  • Behavior:
    • Replace collectorsimulator in preview.go with collectorsimulator from signoz-otel-collector.
    • Handles ErrInvalidConfig by returning a BadRequest error, otherwise returns an InternalError.
  • Code Removal:
    • Delete collectorsimulator directory and all its contents, including inmemoryexporter and inmemoryreceiver.
  • Imports:
    • Update import path in preview.go to use collectorsimulator from signoz-otel-collector.

This description was created by Ellipsis for 82d4c9a. It will automatically update as commits are pushed.

@github-actions github-actions bot added the chore label Nov 26, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 82d4c9a in 31 seconds

More details
  • Looked at 1242 lines of code in 16 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/app/logparsingpipeline/preview.go:83
  • Draft comment:
    Consider including collectorErrs in the error handling logic to ensure all relevant errors are captured and returned.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. pkg/query-service/app/logparsingpipeline/preview.go:9
  • Draft comment:
    The import statement for the collectorsimulator package is incorrect. It should be imported from the signoz-otel-collector package, not the query-service package.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_EBGXEIy78rF9bxKU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@raj-k-singh raj-k-singh merged commit 486632b into develop Nov 27, 2024
16 checks passed
@raj-k-singh raj-k-singh deleted the chore/qs-use-collector-simulator-from-signoz-otel-collector branch November 27, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants