Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the fancy text while fetching data #6505

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 22, 2024

Summary

Just a bit of patience, just a little bit’s enough

This is oxymoronic and unnecessarily fancy. Fetching the explorer data takes time. We should just show we are fetching the data rather than "little bit's enough".


Important

Simplifies loading message in common.json and updates LogsExplorer.test.tsx to reflect this change.

  • Behavior:
    • Simplifies loading message in common.json from "Just a bit of patience, just a little bit’s enough ⎯ we’re getting your {{dataSource}}!" to "Retrieving your {{dataSource}}!".
  • Tests:
    • Updates LogsExplorer.test.tsx to check for the new loading message "Retrieving your logs!" instead of the old one.

This description was created by Ellipsis for 61646c4. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Nov 22, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 61646c4 in 13 seconds

More details
  • Looked at 29 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/pages/LogsExplorer/__tests__/LogsExplorer.test.tsx:152
  • Draft comment:
    The test description should be updated to reflect the change in the string being tested. Consider updating the description to something like 'Logs Explorer Page should render with data and show loading state'.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes a string in the localization file and updates the corresponding test. The test checks for the presence of the new string, which is correct. However, the test description should be updated to reflect the change in the string being tested.

Workflow ID: wflow_DeAKJPoRg4tQWH1y


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv enabled auto-merge (squash) November 22, 2024 10:42
@srikanthccv srikanthccv merged commit 7fe4f8c into develop Nov 22, 2024
15 of 16 checks passed
@srikanthccv srikanthccv deleted the update-text branch November 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants