chore: move away from parallel usages of licenses v2 and v3

[vikrantgupta25]

Summary

• in the current approach we were running both licenses v2 and license v3 in parallel which can cause stale keys to be applied to usage and gateway.
• moving away from all the usages of licenses v2 when we toggle the flag.
• added logging at places necessary for debugging if something goes crazy!

Related Issues / PR's

contributes to - https://github.com/SigNoz/platform-pod/issues/304

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to db0fefa in 1 minute and 18 seconds

More details

• Looked at 170 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. ee/query-service/license/db.go:114

• Draft comment:
  The ctx parameter is not used in GetActiveLicense. Consider passing it to database operations for better context management.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function GetActiveLicense in db.go is not using the context parameter effectively. The context should be passed to any database operations to allow for better control over request lifecycles.

2. ee/query-service/license/db.go:137

• Draft comment:
  The ctx parameter is not used in GetActiveLicenseV3. Consider passing it to database operations for better context management.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function GetActiveLicenseV3 in db.go is not using the context parameter effectively. The context should be passed to any database operations to allow for better control over request lifecycles.

3. ee/query-service/license/db.go:83

• Draft comment:
  The ctx parameter is not used in GetActiveLicenseV2. Consider passing it to database operations for better context management.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function GetActiveLicenseV2 in db.go is not using the context parameter effectively. The context should be passed to any database operations to allow for better control over request lifecycles.

4. ee/query-service/app/api/license.go:96

• Draft comment:
  Consider closing the request body after decoding to prevent resource leaks. Use defer r.Body.Close() after checking for errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The applyLicense function in license.go uses json.NewDecoder(r.Body).Decode(&l) without closing the request body. This can lead to resource leaks. The request body should be closed after decoding.

5. ee/query-service/app/api/license.go:90

• Draft comment:
  Avoid using inline styles in React components. Use external stylesheets or styled components instead. This is also applicable at line 91.
• Reason this comment was not posted:
  Comment was on unchanged code.

6. ee/query-service/license/db.go:114

• Draft comment:
  Do not add non-ClickHouse related functions to the ClickHouseReader interface. Use the DAO in the telemetry instance to access such information instead. This is also applicable at line 83.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_Gd0ICVHWQZZqHnAj

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.