feat: trace v4 integration

[nityanandagohain]

Have changes for

• Introduces new flag use-trace-new-schema , which when set true uses all the updated function for the new schema
• Using the flag it decides which query builder to use and which enrichment function to use.

---

• The only piece left after this is updating the TTL api's in query-service

---

Also please be more cautious and strict while reviewing this PR , thanks

FOR #5713

---

Important

Introduces use-trace-new-schema flag to enable new trace schema, updating APIs, models, and constants to support it.

• Behavior:
  • Introduces use-trace-new-schema flag in api.go, server.go, and main.go to toggle new trace schema.
  • Updates GetServicesList, SearchTracesV2, GetTraceAggregateAttributesV2, GetTraceAttributeKeysV2, GetTraceAttributeValuesV2, GetSpanAttributeKeysV2 to use new schema.
  • Modifies telemetry functions GetTotalSpans, GetSpansInLastHeartBeatInterval, GetTagsInfoInLastHeartBeatInterval for new schema.
• Models:
  • Adds SearchSpanResponseItemV2 and TraceSummary to response.go.
• Constants:
  • Updates NewStaticFieldsTraces and DeprecatedStaticFieldsTraces in constants.go.
• Misc:
  • Updates ThresholdRule in threshold_rule.go to support new schema.
  • Adjusts tests in threshold_rule_test.go for new schema.
  • Minor changes in logs.go and logs_test.go for timestamp range handling.

^{This description was created by for c31e9cd. It will automatically update as commits are pushed.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 1ba4d0f in 4 minutes and 56 seconds

More details

• Looked at 2242 lines of code in 26 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. pkg/query-service/main.go:39

• Draft comment:
  Avoid using inline styles in React components. This rule does not apply here as this is not a React component.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The code uses inline styles in the initZapLog function, which is against the rule of avoiding inline styles in React components. However, this is not a React component, so this rule does not apply here. No other issues are found in this file.

2. pkg/query-service/main.go:51

• Draft comment:
  Avoid using inline styles in React components. This rule does not apply here as this is not a React component.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The code uses inline styles in the initZapLog function, which is against the rule of avoiding inline styles in React components. However, this is not a React component, so this rule does not apply here. No other issues are found in this file.

3. pkg/query-service/main.go:89

• Draft comment:
  Avoid using inline styles in React components. This rule does not apply here as this is not a React component.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The code uses inline styles in the initZapLog function, which is against the rule of avoiding inline styles in React components. However, this is not a React component, so this rule does not apply here. No other issues are found in this file.

4. pkg/query-service/main.go:94

• Draft comment:
  Avoid using inline styles in React components. This rule does not apply here as this is not a React component.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The code uses inline styles in the initZapLog function, which is against the rule of avoiding inline styles in React components. However, this is not a React component, so this rule does not apply here. No other issues are found in this file.

Workflow ID: wflow_nJVGVurFSah6sxTB

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[srikanthccv]

I won't be able to review +900 -250 changes in one PR. Please break it down.

[ellipsis-dev]

👍 Looks good to me! Incremental review on d87c1f0 in 41 seconds

More details

• Looked at 87 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. pkg/query-service/model/trace.go:5

• Draft comment:
  The SpanItemV2 struct is a duplicate of the removed SearchSpanResponseItemV2 struct from response.go. Ensure consistency between these definitions.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The SpanItemV2 struct in trace.go is essentially a duplicate of the SearchSpanResponseItemV2 struct that was removed from response.go. This change is consistent with the PR description, which mentions moving models to support the new schema. However, the SpanItemV2 struct should be checked for any discrepancies with the original SearchSpanResponseItemV2 to ensure consistency.

2. pkg/query-service/app/clickhouseReader/reader.go:1137

• Draft comment:
  Use SpanItemV2 consistently across the codebase to avoid confusion and ensure proper organization.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment seems to be suggesting something that is already being addressed by the code change in the diff. There is no additional action required beyond what is already being done. The comment does not provide new information or point out an unresolved issue.
  I might be missing the broader context of the codebase where SpanItemV2 might not be used consistently elsewhere, but the comment does not specify any such instances.
  The comment should specify if there are other instances where SpanItemV2 is not used consistently. Without such information, the comment does not add value.
  The comment does not point out any additional action required beyond what is already being done in the diff. It should be removed as it does not provide new information or point out an unresolved issue.

Workflow ID: wflow_EWJ19z6qt2MX9dMJ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to c31e9cd in 1 minute and 22 seconds

More details

• Looked at 1097 lines of code in 21 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. ee/query-service/app/api/traces.go:30

• Draft comment:
  Remove commented-out code if it's no longer needed to keep the codebase clean and maintainable.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a new flag use-trace-new-schema to toggle between old and new trace schemas. This flag is consistently passed through various components, ensuring that the system can switch between schemas based on this flag. However, there is a potential issue with the commented-out code in searchTraces function in traces.go. The commented code should be removed if it's no longer needed, as it can lead to confusion and clutter the codebase.

2. pkg/query-service/app/clickhouseReader/reader.go:229

• Draft comment:
  Remove commented-out code if it's no longer needed to keep the codebase clean and maintainable.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a new flag use-trace-new-schema and updates various components to use this flag. However, there is a potential issue with the commented-out code in searchTraces function in traces.go. The commented code should be removed if it's no longer needed, as it can lead to confusion and clutter the codebase.

3. pkg/query-service/app/clickhouseReader/reader.go:189

• Draft comment:
  Remove commented-out code if it's no longer needed to keep the codebase clean and maintainable.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a new flag use-trace-new-schema and updates various components to use this flag. However, there is a potential issue with the commented-out code in searchTraces function in traces.go. The commented code should be removed if it's no longer needed, as it can lead to confusion and clutter the codebase.

Workflow ID: wflow_TzEz40CuqtyEk22w

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[srikanthccv]

There is not much to review here. Please throughly test.