Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miopen dialect opt step13 : apply index diff maps in threadwise_copy and threadwise_copy_v2. #226

Merged
merged 50 commits into from
Jun 5, 2021
Merged

Miopen dialect opt step13 : apply index diff maps in threadwise_copy and threadwise_copy_v2. #226

merged 50 commits into from
Jun 5, 2021

Conversation

whchung
Copy link
Contributor

@whchung whchung commented May 24, 2021 •
edited
Loading

This PR use index diff maps for matrix A/B/C, which uses miopen.threadwise_copy and miopen.threadwise_copy_v2 op.

Will revise this PR and implement F_infinite algorithm, based on infrastructure built in #231 #230 #229 #228 .

@whchung whchung requested review from zjing14 and asroy May 24, 2021 02:31
@whchung
Copy link
Contributor Author

whchung commented May 24, 2021

After close scrutiny from @zjing14 and @asroy , existing implementation computing index diff maps needs to be revised and break into smaller PRs. Closing this PR for now.

@whchung whchung closed this May 24, 2021
@whchung whchung added the skip-ci Don't build Jenkins tests label May 26, 2021
@whchung whchung reopened this May 26, 2021
@whchung
Copy link
Contributor Author

whchung commented May 26, 2021

Reopen this PR , will revise it and implement F_infinite algorithm, based on infrastructure built in #231 #230 #229 #228 .

@whchung whchung force-pushed the miopen-dialect-opt-step13 branch from 7e5cfb6 to c74fe8e Compare May 26, 2021 20:55
@whchung whchung mentioned this pull request May 28, 2021
Merged
@whchung whchung force-pushed the miopen-dialect-opt-step13 branch 7 times, most recently from cb930c3 to 9346f71 Compare May 30, 2021 19:28
@whchung whchung mentioned this pull request May 30, 2021
Closed
@whchung whchung added skip-ci Don't build Jenkins tests and removed skip-ci Don't build Jenkins tests labels May 30, 2021
@whchung whchung force-pushed the miopen-dialect-opt-step13 branch 2 times, most recently from 04791d8 to 206ec22 Compare May 30, 2021 20:57
@whchung whchung changed the title Miopen dialect opt step13 : apply index diff maps in miopen.threadwise_copy. Miopen dialect opt step13 : apply index diff maps in threadwise_copy and threadwise_copy_v2. May 30, 2021
@whchung whchung force-pushed the miopen-dialect-opt-step13 branch from 206ec22 to 48d9aed Compare May 31, 2021 01:18
@whchung whchung requested review from ltqin and asleepzzz June 1, 2021 17:32
@whchung whchung changed the title Miopen dialect opt step13 : apply index diff maps in threadwise_copy and threadwise_copy_v2. [DO NOT MERGE] Miopen dialect opt step13 : apply index diff maps in threadwise_copy and threadwise_copy_v2. Jun 1, 2021
@whchung whchung force-pushed the miopen-dialect-opt-step13 branch 4 times, most recently from 4482c15 to a7f2bbc Compare June 1, 2021 21:52
@whchung whchung force-pushed the miopen-dialect-opt-step13 branch from a7f2bbc to cecef1a Compare June 1, 2021 22:22
whchung added 3 commits June 1, 2021 17:30
@whchung
Merge branch 'miopen-dialect' into miopen-dialect-opt-step13
f6739e4
@whchung
Consider Slice in computeIndexDiffMap. Fix Embed parameters in bwd_data.
99a5b42
@whchung
XXX. HACKS for bwd_data.
cd94277 
- Consider Slice in computeIndexDiffMap.
- Fix Embed parameters in bwd_data.
- Populate a fake identity map to prevent it from being optimized.
- Hack a unit test.
@whchung whchung changed the title [DO NOT MERGE] Miopen dialect opt step13 : apply index diff maps in threadwise_copy and threadwise_copy_v2. Miopen dialect opt step13 : apply index diff maps in threadwise_copy and threadwise_copy_v2. Jun 2, 2021
@whchung whchung requested a review from asroy June 2, 2021 00:03
whchung added 4 commits June 1, 2021 19:04
@whchung
Merge branch 'miopen-dialect' into miopen-dialect-opt-step13
9f2d243
@whchung
Revert "XXX FIXME disable a test for conv2d_bwd_data."
ea603b1 
This reverts commit 734c407.
@whchung
Embed affine maps within the metadata of transformations and use them.
6486c63 
Avoid the identity map being optimized away by MLIR when it's embedded as a
part of memref type.

Fix unit tests. Remove those XXX hacks for conv2d_bwd_data.
@whchung
Use constantFold whenever possible.
7347f4d
@whchung
Copy link
Contributor Author

whchung commented Jun 2, 2021

@okakarpa this particular build is very interesting, it seems something is wrong in script.sh ? is it a script used by Jenkins?

http://ml-ci.amd.com:21096/job/MLIR/job/MLIR-downstream-unit-test/3495/console

+ [[ ! -f ./compile_commands.json ]]
/home/jenkins/workspace/MLIR/MLIR-downstream-unit-test@tmp/durable-ded6cd3c/script.sh: 2: /home/jenkins/workspace/MLIR/MLIR-downstream-unit-test@tmp/durable-ded6cd3c/script.sh: [[: not found
[Pipeline] sh
+ python3 ./mlir/utils/jenkins/static-checks/premerge-checks.py
clang-format did not modify any files
clang-tidy found error: mlir/include/mlir/Dialect/MIOpen/LowerMIOpenOps.h:16:10: error: 'mlir/Conversion/AffineToStandard/AffineToStandard.h' file not found [clang-diagnostic-error]
clang-tidy found error: mlir/lib/Dialect/MIOpen/Transforms/PassDetail.h:12:10: error: 'mlir/Pass/Pass.h' file not found [clang-diagnostic-error]
clang-tidy found 2 errors and 0 warnings.

@whchung
Copy link
Contributor Author

whchung commented Jun 3, 2021

jenkins: retest this please.

@whchung whchung mentioned this pull request Jun 4, 2021
Closed
@whchung whchung merged commit 7eb562f into miopen-dialect Jun 5, 2021
@whchung whchung deleted the miopen-dialect-opt-step13 branch June 5, 2021 02:07
@whchung whchung mentioned this pull request Jun 9, 2021
Merged
@whchung whchung mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asroy asroy asroy approved these changes

@zjing14 zjing14 Awaiting requested review from zjing14

@ltqin ltqin Awaiting requested review from ltqin

@asleepzzz asleepzzz Awaiting requested review from asleepzzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whchung @okakarpa @asroy