Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miopen dialect opt step 24: Remove the undesirable LDS barrier within MFMA code emission hot loop. #256

Closed
wants to merge 1 commit into from

Conversation

whchung
Copy link
Contributor

@whchung whchung commented Jun 4, 2021

After #226 / #255 is merged, taking this PR would produce correct results and we could eliminate the undesirable LDS barrier within MFMA code emission hot loop.

@whchung whchung requested review from zjing14 and asroy June 4, 2021 19:38
@whchung
Copy link
Contributor Author

whchung commented Jun 4, 2021

CI failure is expected as #226 and #255 is yet merged. Apply skip-ci tag for now. Will kick off another run after #226 and #255 gets merged.

@whchung whchung added the skip-ci Don't build Jenkins tests label Jun 4, 2021
@whchung
Copy link
Contributor Author

whchung commented Jun 10, 2021

After examining the ISA, it has been determined that we need to do the followings before this PR can be merged:

@whchung
Copy link
Contributor Author

whchung commented Jul 30, 2021

Close this PR for now. Reopen it after other infrastructure is in place.

@whchung whchung closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Don't build Jenkins tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants