Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miopen dialect opt step14 : Defer compose affine maps. #228

Merged
merged 10 commits into from
May 25, 2021
Merged

Miopen dialect opt step14 : Defer compose affine maps. #228

merged 10 commits into from
May 25, 2021

Conversation

whchung
Copy link
Contributor

@whchung whchung commented May 25, 2021

Defer compose affine maps until threadwise_copy and threadwise_copy_v2.

This paves the way for properly implementing F_infinite algorithm for index diff maps.

@whchung whchung requested review from asroy, ltqin and asleepzzz May 25, 2021 02:31
@whchung whchung added the skip-ci Don't build Jenkins tests label May 25, 2021
@whchung whchung removed the skip-ci Don't build Jenkins tests label May 25, 2021
@whchung
Copy link
Contributor Author

whchung commented May 25, 2021

jenkins: retest this please.

1 similar comment
@whchung
Copy link
Contributor Author

whchung commented May 25, 2021

jenkins: retest this please.

@whchung
Copy link
Contributor Author

whchung commented May 25, 2021

@okakarpa For some reason default target is not launched.

@okakarpa
Copy link
Collaborator

@okakarpa For some reason default target is not launched.

The last job it ran on the commit "a22a5716d2e3ea855d918a0114bb21247c931aee" I suspect webhooks are not sending requests can i get access to webhook settings for this project to debug further

http://ml-ci.amd.com:21096/job/MLIR/job/MLIR-downstream-unit-test/3401/console

@whchung
Copy link
Contributor Author

whchung commented May 25, 2021

@okakarpa

@okakarpa For some reason default target is not launched.

The last job it ran on the commit "a22a5716d2e3ea855d918a0114bb21247c931aee" I suspect webhooks are not sending requests can i get access to webhook settings for this project to debug further

http://ml-ci.amd.com:21096/job/MLIR/job/MLIR-downstream-unit-test/3401/console

I just granted you admin access to this project.

@whchung whchung mentioned this pull request May 25, 2021
Merged
@whchung whchung requested a review from zjing14 May 25, 2021 16:51
@okakarpa
Copy link
Collaborator

@okakarpa

@okakarpa For some reason default target is not launched.

The last job it ran on the commit "a22a5716d2e3ea855d918a0114bb21247c931aee" I suspect webhooks are not sending requests can i get access to webhook settings for this project to debug further
http://ml-ci.amd.com:21096/job/MLIR/job/MLIR-downstream-unit-test/3401/console

I just granted you admin access to this project.

The webhooks send the request but it got hanged for some reason i have retriggered the pr by sending an empty commit

commit id: "b5e6a0822cdeb6bb2de6cea6b2aa970e115504c4"

@whchung whchung merged commit d1aa129 into miopen-dialect May 25, 2021
@whchung whchung deleted the miopen-dialect-do-not-compose-affine-maps branch May 25, 2021 19:33
This was referenced May 25, 2021
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asroy asroy asroy approved these changes

@ltqin ltqin Awaiting requested review from ltqin

@asleepzzz asleepzzz Awaiting requested review from asleepzzz

@zjing14 zjing14 Awaiting requested review from zjing14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whchung @okakarpa @asroy