Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward and backward weights padding kernel #264

Merged
merged 11 commits into from
Jun 14, 2021
Merged

Forward and backward weights padding kernel #264

merged 11 commits into from
Jun 14, 2021

Conversation

asleepzzz
Copy link
Contributor

this PR enable padding kernel for forward and backward weights
we can support resnet50 now

@asleepzzz asleepzzz requested a review from whchung June 9, 2021 20:42
whchung
whchung requested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@whchung whchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the first round of quick review.
Will need to do the 2nd round putting more scrutiny on the transforms applied.

mlir/lib/Dialect/MIOpen/Transforms/AffineTransforms.cpp Outdated Show resolved Hide resolved
mlir/lib/Dialect/MIOpen/Transforms/AffineTransforms.cpp Outdated Show resolved Hide resolved
mlir/test/Dialect/MIOpen/lowering_top_level.mlir Outdated Show resolved Hide resolved
mlir/test/Dialect/MIOpen/lowering_top_level.mlir Outdated Show resolved Hide resolved
@whchung whchung requested review from ltqin and asroy June 9, 2021 20:55
whchung
whchung requested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@whchung whchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the 2nd iteration of review. I get the big picture of how you pad the dimensions and set OOB check dimensions. Some comments need to be improved so future developers can understand your logic.

For FIXME, let's discuss in the meeting later.

@whchung
Copy link
Contributor

whchung commented Jun 9, 2021

Please merge or rebase with miopen-dialect, and revert commits introduced in PR #261 . With this PR, #261 is no longer necessary.

@asleepzzz
Copy link
Contributor Author

jenkins: retest this please.

@asleepzzz
Copy link
Contributor Author

can't connect to ci system

whchung
whchung requested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@whchung whchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some additional comments need to be revised. getting closer.

also CI results look fine so far.

@whchung
Copy link
Contributor

whchung commented Jun 11, 2021

can't connect to ci system

CI system is working fine. You should obtain login information from @okakarpa .

whchung
whchung requested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@whchung whchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes to the comments and the PR is good to go

whchung
whchung approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@whchung whchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for getting this monumental work done!

@whchung whchung merged commit 22476dc into miopen-dialect Jun 14, 2021
@whchung whchung deleted the fwd_wrw_padding branch June 14, 2021 16:02
@whchung whchung mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whchung whchung whchung approved these changes

@ltqin ltqin Awaiting requested review from ltqin

@asroy asroy Awaiting requested review from asroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asleepzzz @whchung