Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miopen dialect opt step19 : rename attributes for miopen.transform #243

Merged
merged 12 commits into from
May 31, 2021

Conversation

whchung
Copy link
Contributor

@whchung whchung commented May 28, 2021

@asroy This PR gives you an idea the scope of renaming attributes. And it also gives you an idea that's it's better to have a declarative way to specify coordinate transformations in TableGen, not in C++.

Rename attributes used in miopen.transform. Add lowest_layer attribute.

To help users easily understand the relationship between different
transformations, apply the following naming changes to attributes used
in miopen.transform :

  • source_layout -> lower_layer_layout
  • intermeidate_layout -> lower_layer_layout
  • output_layout -> upper_layer_layout
  • source_dimensions -> lower_layer_dimensions
  • dimensions -> upper_layer_dimensions
  • source_names -> lower_layer_names
  • names -> upper_layer_names
  • source_bounds -> lower_layer_bounds
  • output_bounds -> upper_layer_bounds
  • domain -> lower_layer_bounds
  • range -> upper_layer_bounds

Upper layer is more abstract which has more coordinate transformations
applied. Lower layer has less coordinate transformations applied.

To tame C++ code production path, a lowest_layer attribute is
introduced.

@jerryyin because this PR touches the C++ code generation path so I also invited you to review this PR as there are non-trivial changes to C++ code generation path.

Originally, we rely on the difference between source_layout and intermediate_layout but now there is no intermediate_layout anymore. Everything has been renamed to lower_layer_layout. I have to introduce a new attribute lowest_layer to help C++ code generation path to figure out the lowest level and do appropriate C++ code emission.

This PR is not blocking #226 , although it is indeed better to have it merged before I revise #226 so we have a consistent attribute naming convention across all kinds of coordinate transformations.

@whchung whchung added the skip-ci Don't build Jenkins tests label May 28, 2021
@whchung whchung requested a review from asroy May 28, 2021 20:16
@whchung whchung force-pushed the miopen-dialect-opt-step19 branch 5 times, most recently from ce09f5c to 67c4ef1 Compare May 28, 2021 21:03
@whchung whchung changed the title Miopen dialect opt step19 : rename attributes. Miopen dialect opt step19 : rename attributes for miopen.transform May 28, 2021
@whchung whchung force-pushed the miopen-dialect-opt-step19 branch 2 times, most recently from ca331e3 to 391ca2b Compare May 28, 2021 22:17
@whchung whchung requested a review from jerryyin May 28, 2021 22:17
whchung added 9 commits May 28, 2021 22:23
domain -> output_bounds
range -> source_bounds
To help users easily understand the relationship between different
transformations, apply the following naming changes to attributes used
in miopen.transform:

source_dimensions -> lower_layer_dimensions
dimensions -> upper_layer_dimensions
source_names -> lower_layer_names
names -> upper_layer_names
source_bounds -> lower_layer_bounds
output_bounds -> upper_layer_bounds

Upper layer is more abstract which has more coordinate transformations
applied. Lower layer has less coordinate transformations applied.

To tame C++ code production path, a "lowest_layer" attribute is
introduced.
@whchung whchung force-pushed the miopen-dialect-opt-step19 branch from 391ca2b to f1d782c Compare May 28, 2021 22:31
@whchung whchung removed the skip-ci Don't build Jenkins tests label May 28, 2021
@whchung
Copy link
Contributor Author

whchung commented May 28, 2021

jenkins: retest this please.

@whchung
Copy link
Contributor Author

whchung commented May 30, 2021

jenkins: retest this please.

@whchung whchung requested a review from asleepzzz May 31, 2021 00:46
@whchung whchung merged commit af689f7 into miopen-dialect May 31, 2021
@whchung whchung deleted the miopen-dialect-opt-step19 branch May 31, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants