-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miopen dialect opt step18 : add source_bounds and output_bounds attributes in miopen.transform #242
Conversation
domain -> output_bounds range -> source_bounds
Maybe we should call A/B lower/upper instead of source/output, so we don't need to switch between two opposite naming scheme when we switch between transforming descriptor and transforming coordinate |
Will file it as a separate PR. |
Please refer to #243 for such an implementation. |
Added a custom builder API for
miopen.transform
to populatesource_bounds
andoutput_bounds
attributes inmiopen.transform
.when we transform A to B in
miopen.transform
, the dimension of B becomessource_bounds
, the dimension of A becomesoutput_bounds
, because A would be lower level tensor and B would be the upper level tensor. when we apply coordinate transformations we begin from upper level coordinates.this is also an infrastructure need for
F_infinite
algorithm to properly compute index diff maps for semi-affine transformations such asMerge
.