[tests] Enabled PCH for testing builds that have COMGR enabled (removed WORKAROUND_ISSUE_898) #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed WORKAROUND_ISSUE_898)
|
@junliume @shurale-nkn Please review and push though CI. Thanks! |
atamazov
changed the title
|
@junliume IMO urgency of this is high. |
CI is blocked due to resource limitation, working to resolve it :( |
junliume
approved these changes
Apr 6, 2022
|
@atamazov @shurale-nkn this has to be reverted due to #1506 |
No. The guilty PR is #1419. Please see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1419/files#r834358074 |
@atamazov thanks! Will re-open this one after #1481 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally resolves #898. Additional info:
warpSizeissue when PCH is used. #1469 (comment)