Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Enabled PCH for testing builds that have COMGR enabled (removed WORKAROUND_ISSUE_898) #1478

Merged
merged 1 commit into from
Apr 6, 2022
Merged

[tests] Enabled PCH for testing builds that have COMGR enabled (removed WORKAROUND_ISSUE_898) #1478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ option( MIOPEN_TEST_DRIVER_ITER_MODE Off)
option( MIOPEN_TEST_MIOTENSILE "Test MIOpenTensile path" OFF )
option( MIOPEN_TEST_MLIR "Test for MLIR compilation backend" ${MIOPEN_USE_MLIR} )

option( WORKAROUND_ISSUE_898 "" ON)
option( WORKAROUND_ISSUE_936 "" ON)
option( WORKAROUND_ISSUE_1053 "" ON)

Expand Down Expand Up @@ -272,10 +271,6 @@ function(add_test_command NAME EXE)
add_test(NAME ${NAME} COMMAND ${EXE} ${ARGN})
endif()
endif()

if(WORKAROUND_ISSUE_898 AND MIOPEN_USE_COMGR)
set_property(TEST ${TEST_NAME} PROPERTY ENVIRONMENT MIOPEN_DEBUG_COMGR_HIP_PCH_ENFORCE=0)
endif()
endfunction()

separate_arguments(MIOPEN_TEST_FLAGS_ARGS UNIX_COMMAND ${MIOPEN_TEST_FLAGS})
Expand Down Expand Up @@ -567,10 +562,6 @@ function(add_custom_test NAME)
add_custom_target(${NAME} ${PARSE_UNPARSED_ARGUMENTS})
add_test(NAME ${NAME} COMMAND ${CMAKE_COMMAND} --build ${CMAKE_CURRENT_BINARY_DIR} --target ${NAME})

if(WORKAROUND_ISSUE_898 AND MIOPEN_USE_COMGR)
set_property(TEST ${NAME} PROPERTY ENVIRONMENT MIOPEN_DEBUG_COMGR_HIP_PCH_ENFORCE=0)
endif()

if(WORKAROUND_ISSUE_1148
AND (${NAME} MATCHES "test_conv_3d"
OR ${NAME} MATCHES "test_conv_group"
Expand Down