Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tensor reorder][Quality][#issue 1476] Improve naming style and CTest design #1481

Merged
merged 88 commits into from
Apr 7, 2022
Merged

[Tensor reorder][Quality][#issue 1476] Improve naming style and CTest design #1481

merged 88 commits into from
Apr 7, 2022

Conversation

aska-0096
Copy link
Collaborator

  1. Improve naming style.
  2. Modify CTest design, now only --all flag will conduct all the data type test while the default one is --float
  3. Fix some small problems.

carlushuang
carlushuang previously approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@carlushuang carlushuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please keep monitoring clang-format/tidy on CI

@aska-0096 aska-0096 mentioned this pull request Mar 28, 2022
Closed
@aska-0096
Copy link
Collaborator Author

@atamazov Would to re-check that everything is ok with the tensor reorder feature? I'll keep monitoring on CI.

@codecov

This comment was marked as off-topic.

Sign in to view
@junliume junliume changed the title [Tensor reorder] Respond to #issue 1476 [Tensor reorder][Quality][#issue 1476] Improve naming style and CTest design Apr 1, 2022
@aska-0096
Copy link
Collaborator Author

@atamazov ping for review.

@shaojiewang shaojiewang self-requested a review April 2, 2022 12:43
shaojiewang
shaojiewang approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@shaojiewang shaojiewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaojiewang shaojiewang requested a review from carlushuang April 2, 2022 12:44
carlushuang
carlushuang approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@carlushuang carlushuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aska-0096 aska-0096 mentioned this pull request Apr 7, 2022
Merged
@junliume junliume mentioned this pull request Apr 7, 2022
Merged
@junliume junliume merged commit fb4590d into develop Apr 7, 2022
@junliume junliume mentioned this pull request Apr 7, 2022
Merged
atamazov
atamazov reviewed Apr 8, 2022
View reviewed changes
Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes are required still. Thanks.

src/kernels/gpu_general_tensor_reorder_kernel/order.hpp Show resolved Hide resolved
src/kernels/gpu_general_tensor_reorder_kernel/general_tensor_reorder.cpp Show resolved Hide resolved
src/include/miopen/tensor_reorder_util.hpp Show resolved Hide resolved
src/include/miopen/tensor_reorder_util.hpp Show resolved Hide resolved
@atamazov
Copy link
Contributor

@aska-0096 Thank you!

@junliume junliume deleted the tensor_reorder branch August 28, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atamazov atamazov atamazov requested changes

@junliume junliume junliume approved these changes

@shaojiewang shaojiewang shaojiewang approved these changes

@carlushuang carlushuang carlushuang approved these changes

Assignees
No one assigned
Labels
TESTING_CI_PASSED urgency_blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aska-0096 @atamazov @carlushuang @junliume @shaojiewang