[tests] [by Artem] Enabled PCH for testing builds that have COMGR enabled (removed WORKAROUND_ISSUE_898) #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled (removed WORKAROUND_ISSUE_898)
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@JehandadKhan need another approval to merge |
This was referenced Apr 10, 2022
Merged
|
Gentle ping for @JehandadKhan @asroy @zjing14. CI should consider passed. |
|
Update all ROCm 5.2 targeted PR/issues as blockers. |
JehandadKhan
approved these changes
Apr 13, 2022
atamazov
reviewed
Apr 13, 2022
| @@ -24,7 +24,19 @@ | |||
| * | |||
| *******************************************************************************/ | |||
| #ifndef GENERAL_TENSOR_REORDER_UTIL_HPP | |||
| #include <cstdint> | |||
| #ifdef __HIPCC_RTC__ | |||
There was a problem hiding this comment.
@junliume Thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate #1478 after blocking issue has been fixed (#1481 and #1419)