Skip to content

Commit

Permalink
Revert "[tests] Enabled PCH for testing builds that have COMGR enable…
Browse files Browse the repository at this point in the history
…d (removed WORKAROUND_ISSUE_898) (#1478)"

This reverts commit bdf9850.
  • Loading branch information
junliume committed Apr 6, 2022
1 parent 30d569d commit 11a0d6a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ option( MIOPEN_TEST_DRIVER_ITER_MODE Off)
option( MIOPEN_TEST_MIOTENSILE "Test MIOpenTensile path" OFF )
option( MIOPEN_TEST_MLIR "Test for MLIR compilation backend" ${MIOPEN_USE_MLIR} )

option( WORKAROUND_ISSUE_898 "" ON)
option( WORKAROUND_ISSUE_936 "" ON)
option( WORKAROUND_ISSUE_1053 "" ON)

Expand Down Expand Up @@ -271,6 +272,10 @@ function(add_test_command NAME EXE)
add_test(NAME ${NAME} COMMAND ${EXE} ${ARGN})
endif()
endif()

if(WORKAROUND_ISSUE_898 AND MIOPEN_USE_COMGR)
set_property(TEST ${TEST_NAME} PROPERTY ENVIRONMENT MIOPEN_DEBUG_COMGR_HIP_PCH_ENFORCE=0)
endif()
endfunction()

separate_arguments(MIOPEN_TEST_FLAGS_ARGS UNIX_COMMAND ${MIOPEN_TEST_FLAGS})
Expand Down Expand Up @@ -562,6 +567,10 @@ function(add_custom_test NAME)
add_custom_target(${NAME} ${PARSE_UNPARSED_ARGUMENTS})
add_test(NAME ${NAME} COMMAND ${CMAKE_COMMAND} --build ${CMAKE_CURRENT_BINARY_DIR} --target ${NAME})

if(WORKAROUND_ISSUE_898 AND MIOPEN_USE_COMGR)
set_property(TEST ${NAME} PROPERTY ENVIRONMENT MIOPEN_DEBUG_COMGR_HIP_PCH_ENFORCE=0)
endif()

if(WORKAROUND_ISSUE_1148
AND (${NAME} MATCHES "test_conv_3d"
OR ${NAME} MATCHES "test_conv_group"
Expand Down

0 comments on commit 11a0d6a

Please sign in to comment.