fix(app): unload adapters after checking position of labware on adapter on heater shaker module #13803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er on heater shaker module Properly combine dynamic logic for opening the heater shaker latch and offloading the labware and adapters in the correct order during LPC checks of labware on adapters on heater shaker modules Closes RAUT-803
b-cooper
requested review from
mjhuff and
shlokamin
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.1 #13803 +/- ##
=======================================================
- Coverage 71.25% 71.24% -0.01%
=======================================================
Files 1589 1589
Lines 52767 52767
Branches 3453 3453
=======================================================
- Hits 37598 37596 -2
- Misses 14634 14635 +1
- Partials 535 536 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
shlokamin
approved these changes
Oct 17, 2023
|
Will this need to be updated for labware on adapters on the temperature module too? |
|
@sanni-t no we special case the HS, the adapter bit is a red herring |
|
and i just verified this works on a flex! lets merge |
This reverts commit 866e7b5.
|
@b-cooper i reverted your last commit that was meant to fix the mag block orange color since i think its not actually quite right (it broke a test and while trying to fix and untangle the logic i decided i didnt wanna deal with this right now) we can fix the orange color as part as 7.1 |
y3rsh
added a commit
that referenced
this pull request
Oct 25, 2023
* edge: (77 commits) fix(app): update move gantry text in change pipette flow (#13712) fix(app): fix CI after release merge back (#13816) chore(hardware): add opentrons hardware package to ot 2 build (#13770) feat(protocol-designer): correct step count in create file wizard (#13807) feat(protocol-designer): error handling in create file wizard (#13804) fix(app): invalidate OT2 calibration queries when calibration flows complete (#13809) always jog (#13806) chore(app): point updates at dns not s3 (#13798) docs(api): updated Flex default flow rates (#13796) fix(api): Flag pipette as not ready to aspirate after pushing out air (#13728) fix(api, hardware): allow OT3Controller to disable tip motors (#13805) more blank trials; longer scale stabilize wait; submerge 2.5mm (#13788) fix(app): unload adapters after checking position of labware on adapter on heater shaker module (#13803) feat(app): wire up location conflict modal for ODD (#13797) feat(app): add Deck configuration page component (#13784) fix(robot-server): add default to robot serial (#13802) feat(protocol-designer, components): prep work for deck config in PD (#13775) feat(app, protocol-designer): plug in waste chute asset (#13800) fix(app): do not check mag block in calibration status (#13799) feat(protocol-designer): edit additional items staging area support (#13752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Properly combine dynamic logic for opening the heater shaker latch and offloading the labware and adapters in the correct order during LPC checks of labware on adapters on heater shaker modules
Closes RAUT-803
Review requests
Risk assessment
low