Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update move gantry text in change pipette flow #13712

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Oct 3, 2023

Overview

This PR updates the pipette attach/detach flows to use updated copy when the gantry is moving.
closes RQA-1224

Risk assessment

Low, just a copy change

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #13712 (ff2af32) into chore_release-7.0.1 (c23b603) will increase coverage by 0.00%.
Report is 2 commits behind head on chore_release-7.0.1.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.0.1   #13712   +/-   ##
====================================================
  Coverage                71.27%   71.28%           
====================================================
  Files                     2427     2427           
  Lines                    68281    68291   +10     
  Branches                  7999     8000    +1     
====================================================
+ Hits                     48669    48678    +9     
  Misses                   17731    17731           
- Partials                  1881     1882    +1     
Flag Coverage Δ
app 68.83% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/ChangePipette/index.tsx 53.76% <100.00%> (ø)

... and 1 file with indirect coverage changes

@shlokamin shlokamin marked this pull request as ready for review October 9, 2023 17:29
@shlokamin shlokamin requested a review from a team as a code owner October 9, 2023 17:29
@shlokamin shlokamin requested review from ncdiehl11 and koji and removed request for a team October 9, 2023 17:29
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shlokamin shlokamin changed the base branch from chore_release-7.0.1 to edge October 19, 2023 20:19
@shlokamin shlokamin merged commit f200aea into edge Oct 20, 2023
@shlokamin shlokamin deleted the app_update-move-gantry-text branch October 20, 2023 15:20
y3rsh added a commit that referenced this pull request Oct 25, 2023
* edge: (77 commits)
  fix(app): update move gantry text in change pipette flow (#13712)
  fix(app): fix CI after release merge back (#13816)
  chore(hardware): add opentrons hardware package to ot 2 build (#13770)
  feat(protocol-designer): correct step count in create file wizard (#13807)
  feat(protocol-designer): error handling in create file wizard (#13804)
  fix(app): invalidate OT2 calibration queries when calibration flows complete (#13809)
  always jog (#13806)
  chore(app): point updates at dns not s3 (#13798)
  docs(api): updated Flex default flow rates (#13796)
  fix(api): Flag pipette as not ready to aspirate after pushing out air (#13728)
  fix(api, hardware): allow OT3Controller to disable tip motors (#13805)
  more blank trials; longer scale stabilize wait; submerge 2.5mm (#13788)
  fix(app): unload adapters after checking position of labware on adapter on heater shaker module (#13803)
  feat(app): wire up location conflict modal for ODD (#13797)
  feat(app): add Deck configuration page component (#13784)
  fix(robot-server): add default to robot serial (#13802)
  feat(protocol-designer, components): prep work for deck config in PD (#13775)
  feat(app, protocol-designer): plug in waste chute asset (#13800)
  fix(app): do not check mag block in calibration status (#13799)
  feat(protocol-designer): edit additional items staging area support (#13752)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants