-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): edit additional items staging area support #13752
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13752 +/- ##
==========================================
- Coverage 70.75% 70.67% -0.09%
==========================================
Files 2465 2474 +9
Lines 69346 69527 +181
Branches 8338 8390 +52
==========================================
+ Hits 49069 49139 +70
- Misses 18317 18416 +99
- Partials 1960 1972 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9b480ca
to
15fe28a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the test flow and lgtm! Coded looks good as well - just a couple minor comments/thoughts.
I don't know PD well enough from an architectural/big picture standpoint to comment on that end, but everything seems to make sense as best as I can grasp it! 🥇
b4cb464
to
615b7c5
Compare
* edge: (77 commits) fix(app): update move gantry text in change pipette flow (#13712) fix(app): fix CI after release merge back (#13816) chore(hardware): add opentrons hardware package to ot 2 build (#13770) feat(protocol-designer): correct step count in create file wizard (#13807) feat(protocol-designer): error handling in create file wizard (#13804) fix(app): invalidate OT2 calibration queries when calibration flows complete (#13809) always jog (#13806) chore(app): point updates at dns not s3 (#13798) docs(api): updated Flex default flow rates (#13796) fix(api): Flag pipette as not ready to aspirate after pushing out air (#13728) fix(api, hardware): allow OT3Controller to disable tip motors (#13805) more blank trials; longer scale stabilize wait; submerge 2.5mm (#13788) fix(app): unload adapters after checking position of labware on adapter on heater shaker module (#13803) feat(app): wire up location conflict modal for ODD (#13797) feat(app): add Deck configuration page component (#13784) fix(robot-server): add default to robot serial (#13802) feat(protocol-designer, components): prep work for deck config in PD (#13775) feat(app, protocol-designer): plug in waste chute asset (#13800) fix(app): do not check mag block in calibration status (#13799) feat(protocol-designer): edit additional items staging area support (#13752) ...
closes RAUT-725, RAUT-742, RAUT-776, RAUT-763
Overview
This adds the ability to edit the staging areas that were initially added and updates the designs of the edit additional items section a bit so the designs are more cohesive.
Test Plan
Changelog
StagingAreasRow
andStagingAreasModal
and testsFlexSlotMap
getSlotIsEmpty
util to account for the staging areasInitialDeckSetup
to take into account staging areasAdditionalItemsRow
andModuleRow
components to use the newFlexSlotMap
TrashModal
and a few other componentsReview requests
see test plan
Risk assessment
low