chore(app): point updates at dns not s3 #13798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're properly pointing at the builds.opentrons.com _bucket_ for release installs, but we were using the s3 provider config which will hit the s3 bucket's public url and not hit the CDN (or the DNS, for that matter, which is like half the point of doing this...). So change that to look at the actual normal url https://builds.opentrons.com/app in the same way we do for internal releases.
sfoster1
force-pushed
the
use-cloudfront-for-publish-app-build
branch
from
d551a18 to
526ff90
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13798 +/- ##
=======================================
Coverage 70.75% 70.75%
=======================================
Files 2465 2465
Lines 69346 69346
Branches 8338 8338
=======================================
Hits 49069 49069
Misses 18317 18317
Partials 1960 1960
Flags with carried forward coverage won't be shown. Click here to find out more. |
shlokamin
approved these changes
Oct 18, 2023
y3rsh
added a commit
that referenced
this pull request
Oct 25, 2023
* edge: (77 commits) fix(app): update move gantry text in change pipette flow (#13712) fix(app): fix CI after release merge back (#13816) chore(hardware): add opentrons hardware package to ot 2 build (#13770) feat(protocol-designer): correct step count in create file wizard (#13807) feat(protocol-designer): error handling in create file wizard (#13804) fix(app): invalidate OT2 calibration queries when calibration flows complete (#13809) always jog (#13806) chore(app): point updates at dns not s3 (#13798) docs(api): updated Flex default flow rates (#13796) fix(api): Flag pipette as not ready to aspirate after pushing out air (#13728) fix(api, hardware): allow OT3Controller to disable tip motors (#13805) more blank trials; longer scale stabilize wait; submerge 2.5mm (#13788) fix(app): unload adapters after checking position of labware on adapter on heater shaker module (#13803) feat(app): wire up location conflict modal for ODD (#13797) feat(app): add Deck configuration page component (#13784) fix(robot-server): add default to robot serial (#13802) feat(protocol-designer, components): prep work for deck config in PD (#13775) feat(app, protocol-designer): plug in waste chute asset (#13800) fix(app): do not check mag block in calibration status (#13799) feat(protocol-designer): edit additional items staging area support (#13752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're properly pointing at the builds.opentrons.com bucket for release
installs, but we were using the s3 provider config which will hit the s3
bucket's public url and not hit the CDN (or the DNS, for that matter,
which is like half the point of doing this...). So change that to look
at the actual normal url https://builds.opentrons.com/app in the same
way we do for internal releases.