Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain level to wave gridded COM path #3137

Merged

Conversation

AntonMFernando-NOAA
Copy link
Contributor

@AntonMFernando-NOAA AntonMFernando-NOAA commented Dec 3, 2024

Description

  • This pull request addresses the organization of wave gridded products within the file structure. Currently, all wave gridded products are placed in products/wave/gridded, without any further categorization. To align with the structure used by other component products (such as grib2), this update introduces a domain/resolution directory level to group output more effectively.

  • For example, instead of having all products in a single directory, the structure will now include specific directories based on domain and resolution (e.g., products/wave/gridded/arctic.9km, products/wave/gridded/global.0p16). This change improves organization and scalability for wave gridded product outputs.

  • Resolves Add domain level to wave gridded COM path #2677

Type of change

  • COM_WAVE_GRID_TMPL updated (or a new template, similar to COM_ATMOS_GRIB_TMP and COM_ATMOS_GRIB_GRID_TMPL) to include a directory level for the domain and resolution
  • Gridded wave output placed into separate directories based on domain/resolution within products/wave/gridded
  • Output otherwise remain unchanged

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • CI tests with HERA and HERCULES

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

jobs/JGLOBAL_ARCHIVE Fixed Show fixed Hide fixed
jobs/JGLOBAL_ARCHIVE Fixed Show fixed Hide fixed
jobs/JGLOBAL_ARCHIVE Fixed Show fixed Hide fixed
jobs/JGLOBAL_WAVE_POST_SBS Fixed Show fixed Hide fixed
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jan 21, 2025
@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C48_ATM FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C48_ATM_919736ac/logs/2021032318/gfs_metpg2o1.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 21, 2025
@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C48_ATM FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/EXPDIR/C48_ATM_919736ac

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C96C48_hybatmDA_919736ac/logs/2021122100/gfs_metpg2o1.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/EXPDIR/C96C48_hybatmDA_919736ac

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C96_atm3DVar FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C96_atm3DVar_919736ac/logs/2021122100/gfs_metpg2o1.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_919736ac/logs/2021122018/gfs_metpg2o1.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C96_atm3DVar FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/EXPDIR/C96_atm3DVar_919736ac

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_919736ac

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C48_S2SW FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C48_S2SW_919736ac/logs/2021032318/gfs_metpg2o1.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Jan 21, 2025

Experiment C48_S2SW FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/EXPDIR/C48_S2SW_919736ac

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Jan 21, 2025
@emcbot
Copy link

emcbot commented Jan 21, 2025

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3137


Experiment C96_S2SWA_gefs_replay_ics_919736ac Completed 1 Cycles: *SUCCESS* at Tue Jan 21 10:36:08 UTC 2025
Experiment C48mx500_3DVarAOWCDA_919736ac Completed 2 Cycles: *SUCCESS* at Tue Jan 21 10:41:46 UTC 2025
Experiment C48_ATM_919736ac Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Tue Jan 21 10:41:47 UTC 2025
Experiment C48_ATM_919736ac Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C48_ATM_919736ac/logs/2021032318/gfs_metpg2o1.log
Experiment C48mx500_hybAOWCDA_919736ac Completed 2 Cycles: *SUCCESS* at Tue Jan 21 10:48:17 UTC 2025
Experiment C96C48_hybatmDA_919736ac Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Tue Jan 21 11:44:12 UTC 2025
Experiment C96C48_hybatmDA_919736ac Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C96C48_hybatmDA_919736ac/logs/2021122100/gfs_metpg2o1.log
Experiment C96_atm3DVar_919736ac Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Tue Jan 21 11:50:17 UTC 2025
Experiment C96_atm3DVar_919736ac Terminated: *FAIL*
Experiment C96C48_hybatmaerosnowDA_919736ac Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Tue Jan 21 11:50:17 UTC 2025
Experiment C96C48_hybatmaerosnowDA_919736ac Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C96_atm3DVar_919736ac/logs/2021122100/gfs_metpg2o1.log
Error logs:
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_919736ac/logs/2021122018/gfs_metpg2o1.log
Experiment C48_S2SW_919736ac Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Tue Jan 21 12:27:20 UTC 2025
Experiment C48_S2SW_919736ac Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3137/RUNTESTS/COMROOT/C48_S2SW_919736ac/logs/2021032318/gfs_metpg2o1.log
Experiment C48_S2SWA_gefs_919736ac Completed 1 Cycles: *SUCCESS* at Tue Jan 21 12:33:28 UTC 2025
Experiment C96C48_ufs_hybatmDA_919736ac Completed 3 Cycles: *SUCCESS* at Tue Jan 21 12:39:30 UTC 2025

@DavidHuber-NOAA
Copy link
Contributor

@malloryprow @AntonMFernando-NOAA It looks like the metp jobs failed because the required prepbufr files are missing. The reference directory is /scratch1/NCEPDEV/global/Mallory.Row/prepbufr/gdas. Data is available in that directory starting on 20230101. Could data for 20211218-20211224 be added?

@malloryprow
Copy link
Contributor

malloryprow commented Jan 21, 2025

@DavidHuber-NOAA I had cleared days prior to 2023 because of the disk space filling up on Hera under /scratch1/NCEPDEV/global/. I can work on adding these files.

@DavidHuber-NOAA
Copy link
Contributor

Noted, and thank you!

@WalterKolczynski-NOAA
Copy link
Contributor

Tests that didn't run with MET all passed. Going to go ahead and merge this. @DavidHuber-NOAA is going to open a hotfix turning off MET for tests except the atm3DVar tests, and @malloryprow is going to restore the data we need just for those tests (initialized 2021122018 – 2021122118).

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit a72edf4 into NOAA-EMC:develop Jan 21, 2025
9 of 11 checks passed
@JessicaMeixner-NOAA
Copy link
Contributor

JessicaMeixner-NOAA commented Jan 21, 2025

@WalterKolczynski-NOAA apologies for the slownesss on my end, but I was trying to run tests with this branch to confirm things were running for multiple output grids.

The last time I looked late last week there were still changes requested and was just going back to see if those changes had been made. Did someone from the waves side give an approval for this PR? Did someone test multiple output grids for this PR?

@aerorahul
Copy link
Contributor

@WalterKolczynski-NOAA
We might have merged this PR preemptively. @JessicaMeixner-NOAA was still working on this branch to provide review on ensuring that the functionality for multiple output grids is preserved. As she mentions in her review comments earlier, the CI tests do not cover this case due to a low resolution computational grid.
@JessicaMeixner-NOAA
If you could provide a test case yaml/configuration that we can setup and test to ensure the multiple output grids feature is preserved, we could run a test and save the output for your review. If we discover problems, we can create an issue to fix it.
Thank you for your time and effort on reviewing the aspect of the development that the low-resolution test does not cover.

@malloryprow
Copy link
Contributor

@malloryprow @AntonMFernando-NOAA It looks like the metp jobs failed because the required prepbufr files are missing. The reference directory is /scratch1/NCEPDEV/global/Mallory.Row/prepbufr/gdas. Data is available in that directory starting on 20230101. Could data for 20211218-20211224 be added?

I added the files.

tsga added a commit to tsga/global-workflow that referenced this pull request Jan 22, 2025
* develop:
  Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246)
  Add domain level to wave gridded COM path (NOAA-EMC#3137)
  CI JJOB Tests using CMake (NOAA-EMC#3214)
  Make assorted updates to waves (NOAA-EMC#3190)
  Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236)
  Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211)
  Add additional GEFS variables needed for AI/ML applications  (NOAA-EMC#3221)
  Add bmat task dependency to marine LETKF task (NOAA-EMC#3224)
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
  Separate use of initial increment/perturbation file from REPLAY/+03 ICs  (NOAA-EMC#3119)
  Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207)
  Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212)
  Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146)
  Remove multi-grid wave support (NOAA-EMC#3188)
  Add echgres as a dependency for earc (NOAA-EMC#3202)
@AntonMFernando-NOAA AntonMFernando-NOAA deleted the wavegrid_compath branch January 23, 2025 15:39
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Jan 27, 2025
* develop:
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
  Only run METplus in the 3Dvar tests (NOAA-EMC#3245)
  Clone, build, and run C48_ATM and C48_S2SW on Gaea C5 and C6 (NOAA-EMC#3106)
  Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246)
  Add domain level to wave gridded COM path (NOAA-EMC#3137)
  CI JJOB Tests using CMake (NOAA-EMC#3214)
  Make assorted updates to waves (NOAA-EMC#3190)
  Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236)
  Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211)
  Add additional GEFS variables needed for AI/ML applications  (NOAA-EMC#3221)
  Add bmat task dependency to marine LETKF task (NOAA-EMC#3224)
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
  Separate use of initial increment/perturbation file from REPLAY/+03 ICs  (NOAA-EMC#3119)
  Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207)
  Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212)
  Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146)
  Remove multi-grid wave support (NOAA-EMC#3188)
  Add echgres as a dependency for earc (NOAA-EMC#3202)
  Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199)
  Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171)
  Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193)
  Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197)
  Remove early-cycle EnKF forecast (NOAA-EMC#3185)
  Fix mod_icec bug in atmos_prod (NOAA-EMC#3167)
  Create compute build option (NOAA-EMC#3186)
  Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998)
  Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175)
  Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163)
  Update compression options for GEFS history files (NOAA-EMC#3184)
  Update compression options for high res history files (NOAA-EMC#3178)
  Turn DO_TEST_MODE off (NOAA-EMC#3177)
  Hotfix for gdas_arch div/0 (NOAA-EMC#3169)
  Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow (NOAA-EMC#3098)
  Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125)
  Update ufs-weather-model to 2024-12-06 commit  (NOAA-EMC#3145)
  Enable traditional threading as an option (NOAA-EMC#3149)
  Update HPC_ACCOUNT on Hercules to fv3-cpu (NOAA-EMC#3164)
  Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test (NOAA-EMC#3120)
  Update GSI analysis jobs to use COMIN/COMOUT (NOAA-EMC#3092)
  Update HPC Tier Definitions (NOAA-EMC#3138)
  Add marine hybrid envar (NOAA-EMC#3041)
  Archive the experiment directory along with git status/diff output (NOAA-EMC#3105)
  Use stochastic restart patterns on rerun (NOAA-EMC#3077)
  Point Jenkinsfile back to CI/ (NOAA-EMC#3139)
  Fix wave restart for cold start and add ic version file (NOAA-EMC#3112)
  Allow users to override the default account at setup time (NOAA-EMC#3127)
  Refactor gridded wave post (NOAA-EMC#3014)
  Update docs related to NOAA CSPs (NOAA-EMC#3043)
  Allow APP to differ between RUNs (NOAA-EMC#2943)
  Run one executable for soca2cice (instead of two) (NOAA-EMC#3118)
  Speed up GSI analysis jobs in CI testing (NOAA-EMC#3115)
  Make aerosol output frequency variable (NOAA-EMC#2982)
  Add new stations to GFS BUFR sounding products (NOAA-EMC#3107)
  JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring (NOAA-EMC#2992)
  Enable tapering of atm ens perts at the model top (NOAA-EMC#3097)
  Update JGDAS ENKF POST  job  (NOAA-EMC#3090)
  SFS Runs at C96mx100  (NOAA-EMC#2960)
  Move machine-based options from config.base to host files (NOAA-EMC#3053)
  Remove RUNDIRS before running CI cases to cover re-run events (NOAA-EMC#3076)
  CI GitHub pipeline (hotfix) update for fetching repo name (NOAA-EMC#3084)
  Update JGDAS ENKF ECEN job  (NOAA-EMC#3050)
  Update snow obs processing job (NOAA-EMC#3055)
  Update to action workflow pipeline in default repo for development  (NOAA-EMC#3062)
  Update to action workflow pipeline in default repo for development (NOAA-EMC#3061)
  Update workflow pipeline (NOAA-EMC#3060)
  PW CI pipeline update5 ready for review so it can be merged and tested (NOAA-EMC#3059)
  Revert "GitHub CI Pipeline update for debugging forked PR support" (NOAA-EMC#3057)
  GitHub CI Pipeline update for debugging forked PR support (NOAA-EMC#3056)
  Add more ocean variables for post-processing in GEFS (NOAA-EMC#2995)
  Auto provisioning of PW clusters from GitHub CI added (NOAA-EMC#3051)
  Fix the name of the TC tracker filenames in archive.py (NOAA-EMC#3030)
  Make wxflow links static instead of from link_workflow (NOAA-EMC#3008)
  Update global jdas enkf diag job with COMIN/COMOUT for COM prefix (NOAA-EMC#2959)
  Add run and finalize methods to marine LETKF task (NOAA-EMC#2944)
  Fix wave restarts and GEFS FHOUT/FHMAX (NOAA-EMC#3009)
  Disabling hyper-threading (NOAA-EMC#2965)
  GitHub Actions Pipeline Updates for Self-Hosted Runners on PW (NOAA-EMC#3018)
  CI jekninsfile update hotfix (NOAA-EMC#3038)
  Update gdas.cd (NOAA-EMC#2978)
  Add ability to add tag to pslots with generate_workflows (NOAA-EMC#3036)
  CI update to shell environment with HOMEgfs to HOME_GFS for systems that need the path (NOAA-EMC#3013)
  Quick updated to Jenkins (health check) launch script (NOAA-EMC#3033)
  Document the generate_workflows.sh script (NOAA-EMC#3028)
  Replace gfs_cyc with an interval (NOAA-EMC#2928)
  Hotfix: Fix generate_workflows.sh optional build flags (NOAA-EMC#3024)
  Add a tool to run multiple YAML cases locally (NOAA-EMC#3004)
  Hotfix: Correctly set overwrite option when specified (NOAA-EMC#3021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add domain level to wave gridded COM path
7 participants