Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HPC Tier Definitions #3138

Merged
merged 25 commits into from
Dec 9, 2024
Merged

Update HPC Tier Definitions #3138

merged 25 commits into from
Dec 9, 2024

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Dec 3, 2024 •
edited
Loading

Description

Updates the tier definitions for supported platforms. This also updates and reformats the README.
Note that the README badges will display errors until this PR is merged. @TerrenceMcGuinness-NOAA updated the gist, so the badges are now showing up correctly in the README.

Resolves #3135

Type of change

  • Documentation update

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? YES

How has this been tested?

Checked the rendered README.md.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have made corresponding changes to the system documentation if necessary

KateFriedman-NOAA
KateFriedman-NOAA requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on the .github/workflows/*.yaml files but the README.md updates look good. Left one suggested change.

README.md Outdated Show resolved Hide resolved
@DavidHuber-NOAA @KateFriedman-NOAA
Update README.md
4e8434f 
Co-authored-by: Kate Friedman <[email protected]>
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as draft December 3, 2024 20:10
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review December 3, 2024 20:51
@DavidHuber-NOAA
Copy link
Contributor Author

I'm not sure how to get consistent spacing inside of the table column headers. I may try some other options tomorrow.

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DavidHuber-NOAA !

@aerorahul aerorahul merged commit 6c5b9bb into NOAA-EMC:develop Dec 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA left review comments

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA left review comments

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA

@JacobCarley-NOAA JacobCarley-NOAA Awaiting requested review from JacobCarley-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Machine Support Documentation
5 participants
@DavidHuber-NOAA @JessicaMeixner-NOAA @WalterKolczynski-NOAA @KateFriedman-NOAA @aerorahul