Copy post-processed sea ice increment for diagnostics #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlyaeva
requested review from
guillaumevernieres and
AndrewEichmann-NOAA
as code owners
6 tasks
AndrewEichmann-NOAA
previously approved these changes
Jan 16, 2025
aerorahul
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
looks good to me.
Requesting review from @RussTreadon-NOAA and @DavidNew-NOAA since this updates the gdasapp hash in the workflow
DavidNew-NOAA
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
@aerorahul It looks like the content of the GDASApp hash update is pretty minimal and directly related to the purpose of this PR, so I'm fine with it.
|
Before we move forward with this PR we need to
|
|
I'll work on downstream merges and updates on Tuesday; thank you all for quick reviews and @RussTreadon-NOAA for outlining the steps forward! |
WalterKolczynski-NOAA
previously approved these changes
Jan 21, 2025
guillaumevernieres
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 22, 2025
# Description Add plots to offline vrfy to output postprocessed (aka what get added to CICE restart) sea ice increment. # Companion PRs NOAA-EMC/jcb-gdas#64 NOAA-EMC/global-workflow#3235 # Issues Resolves #1402 # Automated CI tests to run in Global Workflow Since it's offline vrfy, no tests would cover it currently. <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmaerosnowDA <!-- JEDI aero/snow cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !--> --------- Co-authored-by: Anna Shlyaeva <[email protected]>
shlyaeva
dismissed stale reviews from aerorahul, guillaumevernieres, WalterKolczynski-NOAA, AndrewEichmann-NOAA, and DavidNew-NOAA
via
ea0a772
|
I've updated GDASApp hash after the PR was merged, I think this should be ready for testing now. |
|
Thank you @shlyaeva. I will install and test on Orion. |
guillaumevernieres
approved these changes
Jan 23, 2025
|
Orion g-w CI |
RussTreadon-NOAA
approved these changes
Jan 23, 2025
RussTreadon-NOAA
added
the
CI-Hera-Ready
emcbot
added
the
CI-Hera-Building
aerorahul
added
the
CI-Hercules-Ready
emcbot
added
CI-Hercules-Building
RussTreadon-NOAA
added
the
CI-Wcoss2-Ready
emcbot
added
CI-Hercules-Running
KateFriedman-NOAA
removed
the
CI-Wcoss2-Ready
emcbot
added
CI-Wcoss2-Running
|
CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3235/RUNTESTS on WCOSS |
|
@RussTreadon-NOAA To add to what @aerorahul said, I saw the WCOSS2-ready label when I checked this morning and then fired off the CI tests on WCOSS2. I then manually removed the ready label. The scripts I am now monitoring on WCOSS2 changed the label to "building" and will update it to "running" once at that point. I'll monitor the status during the day and either report failures or success. For future reference, if you set the label to ready on WCOSS2 mid-way through the day, feel free to poke me so it doesn't wait until I check at the end of my day. Thanks! |
emcbot
added
CI-Hera-Passed
|
CI Passed on Hera in Build# 1 |
|
The Hera CI end-to-end tests finished in 4hrs 20 mins (from CI-Hera-Ready to CI-Hera-Passed) |
emcbot
added
CI-Hercules-Passed
|
CI Passed on Hercules in Build# 2 |
|
WCOSS2 (Cactus) g-w CI update g-w CI cases set to be run on WCOSS2 have been successfully completed apart from C96_atm3DVar_extended. The C96_atm3DVar_extended case is stuck waiting for three gfs_arch jobs to run Each of these job remains queued due to The C96_atm3DVar_extended 20211221 18Z cycle can not start because Does g-w CI have the ability to select which g-w CI cases to run? This option is available in GDASApp PRs. g-w PR #3235 does not, to my knowledge, modify anything exercised in the C96_atm3DVar_extended case. |
KateFriedman-NOAA
added
CI-Wcoss2-Passed
|
@RussTreadon-NOAA I manually set the WCOSS2-passed label. Only one gfs_arch job remains to run but it's far enough to show it's working. Thanks for noticing some are sitting in the queue a while! We can investigate memory needs for these jobs on WCOSS2...I'm not sure if that's been evaluated for a while. It may be that WCOSS2 is just that busy on the transfer nodes right now but the correct memory should be analyzed. |
|
Thank you @KateFriedman-NOAA |
|
WCOSS2 CI - conclusion g-w CI case C96_atm3DVar_extended successfully ran to completion on Cactus The total time to run this case is 13:15:04. We should
|
|
@WalterKolczynski-NOAA , can this PR be merged into GDASApp |
|
Thank you @aerorahul |
danholdaway
added a commit
to danholdaway/global-workflow
that referenced
this pull request
Jan 27, 2025
* develop: Remove WAFS files and references from `develop` (NOAA-EMC#3263) fix intel stack version number on c5 (NOAA-EMC#3258) Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252) Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255) Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235) Only run METplus in the 3Dvar tests (NOAA-EMC#3245) Clone, build, and run C48_ATM and C48_S2SW on Gaea C5 and C6 (NOAA-EMC#3106) Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246) Add domain level to wave gridded COM path (NOAA-EMC#3137) CI JJOB Tests using CMake (NOAA-EMC#3214) Make assorted updates to waves (NOAA-EMC#3190) Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236) Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211) Add additional GEFS variables needed for AI/ML applications (NOAA-EMC#3221) Add bmat task dependency to marine LETKF task (NOAA-EMC#3224) Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206) Separate use of initial increment/perturbation file from REPLAY/+03 ICs (NOAA-EMC#3119) Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207) Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212) Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146) Remove multi-grid wave support (NOAA-EMC#3188) Add echgres as a dependency for earc (NOAA-EMC#3202) Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199) Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171) Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193) Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197) Remove early-cycle EnKF forecast (NOAA-EMC#3185) Fix mod_icec bug in atmos_prod (NOAA-EMC#3167) Create compute build option (NOAA-EMC#3186) Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998) Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175) Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163) Update compression options for GEFS history files (NOAA-EMC#3184) Update compression options for high res history files (NOAA-EMC#3178) Turn DO_TEST_MODE off (NOAA-EMC#3177) Hotfix for gdas_arch div/0 (NOAA-EMC#3169) Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow (NOAA-EMC#3098) Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125) Update ufs-weather-model to 2024-12-06 commit (NOAA-EMC#3145) Enable traditional threading as an option (NOAA-EMC#3149) Update HPC_ACCOUNT on Hercules to fv3-cpu (NOAA-EMC#3164) Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test (NOAA-EMC#3120) Update GSI analysis jobs to use COMIN/COMOUT (NOAA-EMC#3092) Update HPC Tier Definitions (NOAA-EMC#3138) Add marine hybrid envar (NOAA-EMC#3041) Archive the experiment directory along with git status/diff output (NOAA-EMC#3105) Use stochastic restart patterns on rerun (NOAA-EMC#3077) Point Jenkinsfile back to CI/ (NOAA-EMC#3139) Fix wave restart for cold start and add ic version file (NOAA-EMC#3112) Allow users to override the default account at setup time (NOAA-EMC#3127) Refactor gridded wave post (NOAA-EMC#3014) Update docs related to NOAA CSPs (NOAA-EMC#3043) Allow APP to differ between RUNs (NOAA-EMC#2943) Run one executable for soca2cice (instead of two) (NOAA-EMC#3118) Speed up GSI analysis jobs in CI testing (NOAA-EMC#3115) Make aerosol output frequency variable (NOAA-EMC#2982) Add new stations to GFS BUFR sounding products (NOAA-EMC#3107) JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring (NOAA-EMC#2992) Enable tapering of atm ens perts at the model top (NOAA-EMC#3097) Update JGDAS ENKF POST job (NOAA-EMC#3090) SFS Runs at C96mx100 (NOAA-EMC#2960) Move machine-based options from config.base to host files (NOAA-EMC#3053) Remove RUNDIRS before running CI cases to cover re-run events (NOAA-EMC#3076) CI GitHub pipeline (hotfix) update for fetching repo name (NOAA-EMC#3084) Update JGDAS ENKF ECEN job (NOAA-EMC#3050) Update snow obs processing job (NOAA-EMC#3055) Update to action workflow pipeline in default repo for development (NOAA-EMC#3062) Update to action workflow pipeline in default repo for development (NOAA-EMC#3061) Update workflow pipeline (NOAA-EMC#3060) PW CI pipeline update5 ready for review so it can be merged and tested (NOAA-EMC#3059) Revert "GitHub CI Pipeline update for debugging forked PR support" (NOAA-EMC#3057) GitHub CI Pipeline update for debugging forked PR support (NOAA-EMC#3056) Add more ocean variables for post-processing in GEFS (NOAA-EMC#2995) Auto provisioning of PW clusters from GitHub CI added (NOAA-EMC#3051) Fix the name of the TC tracker filenames in archive.py (NOAA-EMC#3030) Make wxflow links static instead of from link_workflow (NOAA-EMC#3008) Update global jdas enkf diag job with COMIN/COMOUT for COM prefix (NOAA-EMC#2959) Add run and finalize methods to marine LETKF task (NOAA-EMC#2944) Fix wave restarts and GEFS FHOUT/FHMAX (NOAA-EMC#3009) Disabling hyper-threading (NOAA-EMC#2965) GitHub Actions Pipeline Updates for Self-Hosted Runners on PW (NOAA-EMC#3018) CI jekninsfile update hotfix (NOAA-EMC#3038) Update gdas.cd (NOAA-EMC#2978) Add ability to add tag to pslots with generate_workflows (NOAA-EMC#3036) CI update to shell environment with HOMEgfs to HOME_GFS for systems that need the path (NOAA-EMC#3013) Quick updated to Jenkins (health check) launch script (NOAA-EMC#3033) Document the generate_workflows.sh script (NOAA-EMC#3028) Replace gfs_cyc with an interval (NOAA-EMC#2928) Hotfix: Fix generate_workflows.sh optional build flags (NOAA-EMC#3024) Add a tool to run multiple YAML cases locally (NOAA-EMC#3004) Hotfix: Correctly set overwrite option when specified (NOAA-EMC#3021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change copies post-processed sea ice increment (the increment that was added to CICE restart files, as opposed to the raw increment that was produced by SOCA), so it can be used in the verification/diagnostics.
It also cleans up previously committed code (removes a list of files where it's not needed anymore).
Resolves NOAA-EMC/GDASApp#1402
Type of change
Change characteristics
How has this been tested?
Checklist