Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain level to wave gridded COM path #2677

Closed
3 tasks
WalterKolczynski-NOAA opened this issue Jun 11, 2024 · 0 comments · Fixed by #3137
Closed
3 tasks

Add domain level to wave gridded COM path #2677

WalterKolczynski-NOAA opened this issue Jun 11, 2024 · 0 comments · Fixed by #3137
Assignees
@AntonMFernando-NOAA
Labels
feature New feature or request

Comments

@WalterKolczynski-NOAA
Copy link
Contributor

What new functionality do you need?

Wave gridded products are currently all being placed in products/wave/gridded. Other component products include a domain/resolution directory level to group output (e.g. grib2 has a 0p25, 0p50, and 1p00 directory). Wave gridded products should also include this level (e.g. products/wave/gridded/arctic.9km, products/wave/gridded/global.0p16, etc)

What are the requirements for the new functionality?

Gridded wave output is placed into separate directories based on domain/resolution combination.`

Acceptance Criteria

  • COM_WAVE_GRID_TMPL updated (or a new template, similar to COM_ATMOS_GRIB_TMP and COM_ATMOS_GRIB_GRID_TMPL) to include a directory level for the domain and resolution
  • Gridded wave output placed into separate directories based on domain/resolution within products/wave/gridded
  • Output otherwise remain unchanged

Suggest a solution (optional)

No response
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the feature New feature or request label Jun 11, 2024
@AntonMFernando-NOAA AntonMFernando-NOAA self-assigned this Dec 2, 2024
@AntonMFernando-NOAA AntonMFernando-NOAA mentioned this issue Dec 3, 2024
Merged
13 tasks
WalterKolczynski-NOAA pushed a commit that referenced this issue Jan 21, 2025
@AntonMFernando-NOAA
Add domain level to wave gridded COM path (#3137)
a72edf4 
This pull request addresses the organization of wave gridded products
within the file structure. Currently, all wave gridded products are
placed in products/wave/gridded, without any further categorization. To
align with the structure used by other component products (such as
grib2), this update introduces a domain/resolution directory level to
group output more effectively.

For example, instead of having all products in a single directory, the
structure will now include specific directories based on domain and
resolution (e.g., products/wave/gridded/arctic.9km,
products/wave/gridded/global.0p16). This change improves organization
and scalability for wave gridded product outputs.

Resolves #2677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonMFernando-NOAA AntonMFernando-NOAA

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add domain level to wave gridded COM path AntonMFernando-NOAA/global-workflow
2 participants
@WalterKolczynski-NOAA @AntonMFernando-NOAA