[FEATURE BRANCH] 902 E&A breakout #1154
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
🤚 I am having hard time running the branch on Next repo, getting an error from the line that uses |
Yes, I had the same problem and fixed it in my map controls branch: https://github.com/NASA-IMPACT/veda-ui/pull/1205/files#diff-c01e76db4162d7ec2d29c4cd98dcadb5826d1ead020f96f94159a72d77d7b3b5R6 |
|
@hanbyul-here @dzole0311 yep, i highlighed that in an earlier PR - seems to be a known issue with parcel #1046 (comment) |
… library, and get to render in nextJs instance
sandrahoang686
force-pushed
the
902-ea-breakout
branch
from
7771378
to
e130a6a
Compare
**Related Ticket:** #1154 ### Description of Changes * Fixed to have changes from https://github.com/NASA-IMPACT/veda-ui/pull/1231/files# which I accidentally removed when resolving conflicts in main feature branch * Remove `onClick` from `LinkProperties` * When something is a link, it doesn't need an onClick event... The onClick event should be placed on the `Card` Component instead of link props * LinkProperties should not be required for the card component. Only when the card re-routes would it need the linkProperties. For example, cards on the dataset selector modal dont re-route and we shouldn't have to pass in linkProps * Remove try/catch around aoi area/point selection logic and into local state with useEffect ### Note Built `v5.9.1-ea.0` off of these changes Update: Bulit `v5.9.1-ea.1` has been built ### Validation / Testing * Please make sure Dataset Layer Selection modal and E&A works as expected * Please make sure all cards in the dashboard are working as expected * Make sure external cards link externally and have the external badge * Make sure internal cards link internally correctly * Make sure Dataset Layer Selection modal selects cards as expected **NextJs Preview with updated version:** developmentseed/next-veda-ui#4
sandrahoang686
requested review from
hanbyul-here,
dzole0311,
AliceR and
vgeorge
|
Leaving a note of UI changes that is not intended (I will add if I find more - also feel free to modify this comment if anybody finds anything.)
|
|
@hanbyul-here thanks for catching, created an issue for that here as i dont think its blocking 👍🏼 Update: We actually want that behavior of the cursor change because we removed linking from datalayer selector cards so unfiling but kept placeholder ticket open |
### 🚀 Improvements * Exploration & Analysis core VEDA feature breakout #1251 #1154 * Introduce `EnvConfigProvider` to simplify the injection of environment variables from host applications like Next.js #1253 * Remove React Router's `useNavigate` dependency for simplifying the routing #1270 ### 🐛 Fixes * Fix an issue where card images fail to maintain the correct aspect ratio #1265
Related Ticket: #902
Description of Changes
Related NextJs PR/Branch: developmentseed/next-veda-ui#4
GHG Preview with this branch pulled in generated here => US-GHG-Center/veda-config-ghg#659
Iteration 1 - Issue #902, changes by @sandrahoang686
ExplorationAndAnalysiscomponenttimelineDatasetsAtomto be used NextJs sideDatasetSelectorModalout ofExplorationAndAnalysis. ExplorationAndAnalysis only needs to know the dataset layers to be displayed. DatasetSelectorModal or whatever layer selection method should be controlled at the parent level aboveExplorationAndAnalysis.ExplorationAndAnalysisin NextJs instanceAnalysisMessageControlCustomAoIControlNotes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing