Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE BRANCH] 902 E&A breakout #1154

Merged
merged 39 commits into from
Nov 14, 2024
Merged

[FEATURE BRANCH] 902 E&A breakout #1154

merged 39 commits into from
Nov 14, 2024

Commits on Nov 11, 2024

  1. Expose ExplorationAndAnalysis component, update date-fns for building… 

    … library, and get to render in nextJs instance
    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7ffa351 View commit details
    Browse the repository at this point in the history

  2. Comment out analysis message for now

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7061c7f View commit details
    Browse the repository at this point in the history

  3. Decouple datasets selector modal from E&A

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a6dfab5 View commit details
    Browse the repository at this point in the history

  4. fix datepicker and abandom modal version

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ef45523 View commit details
    Browse the repository at this point in the history

  5. clean some things up and uncomment things out

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    11eb134 View commit details
    Browse the repository at this point in the history

  6. Uncomment and comment out source of breakage for analysis-message-con… 

    …trol
    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a31fc6d View commit details
    Browse the repository at this point in the history

  7. add comment

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bcbf657 View commit details
    Browse the repository at this point in the history

  8. Fix draw controls and analysis message

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ad732f7 View commit details
    Browse the repository at this point in the history

  9. Fix lint

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9f4e65c View commit details
    Browse the repository at this point in the history

  10. Fix unmount error

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9afeaaa View commit details
    Browse the repository at this point in the history

  11. Clean up

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    af34511 View commit details
    Browse the repository at this point in the history

  12. Switch to non-ref object usage

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    39dfb20 View commit details
    Browse the repository at this point in the history

  13. Remove obsolete code and add a comment

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    df5da6c View commit details
    Browse the repository at this point in the history

  14. Make dataselectormodal exportable

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1a6cff1 View commit details
    Browse the repository at this point in the history

  15. Put onClick props directly

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0c08048 View commit details
    Browse the repository at this point in the history

  16. Consolidate onLinkClick and onClick into onClick

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    db9e3c1 View commit details
    Browse the repository at this point in the history

  17. Revert fix attempt

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    103b3f6 View commit details
    Browse the repository at this point in the history

  18. Fix imports

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    20ac2a9 View commit details
    Browse the repository at this point in the history

  19. Add missing import

    @dzole0311 @sandrahoang686
    dzole0311 authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    165906e View commit details
    Browse the repository at this point in the history

  20. Export useAtom, Remove any react router related components

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6d6047e View commit details
    Browse the repository at this point in the history

  21. Use a when opening a tab in a new window

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a538d20 View commit details
    Browse the repository at this point in the history

  22. Use linkproperties for sources (but is this necessary?)

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fb09159 View commit details
    Browse the repository at this point in the history

  23. Flag the problem - 1

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fb269d0 View commit details
    Browse the repository at this point in the history

  24. Edit date atom (workaround)

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3d89476 View commit details
    Browse the repository at this point in the history

  25. Make a comment where it uses data faux module datasetLayers

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    acafa2e View commit details
    Browse the repository at this point in the history

  26. Put Try Catch block for drawcontrol function

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    090c256 View commit details
    Browse the repository at this point in the history

  27. Add last array method

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    86c90c3 View commit details
    Browse the repository at this point in the history

  28. Revert temporary work around

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    529d6aa View commit details
    Browse the repository at this point in the history

  29. Get rid of the line that is not necessary

    @hanbyul-here @sandrahoang686
    hanbyul-here authored and sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6107a3c View commit details
    Browse the repository at this point in the history

  30. Resolved all conflicts

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e130a6a View commit details
    Browse the repository at this point in the history

  31. Fix import to fix buildlib error

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f23dac9 View commit details
    Browse the repository at this point in the history

  32. Add is LinkExternal back that was removed from conflict resolution

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    de31403 View commit details
    Browse the repository at this point in the history

  33. Remove onClick from linkProps, Remove linkProps req from card, Fix to… 

    … have externallinkbadge hotfix changes
    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4b59fd6 View commit details
    Browse the repository at this point in the history

  34. remove try/catch around area/point selection logic into useEffect

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8321a12 View commit details
    Browse the repository at this point in the history

  35. Fix to linter and ts error

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c502224 View commit details
    Browse the repository at this point in the history

  36. fix lint error..

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0ec5744 View commit details
    Browse the repository at this point in the history

  37. Fix lint error again.. ugh

    @sandrahoang686
    sandrahoang686 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bee9d96 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. add updated state to aoi use effect dep array

    @sandrahoang686
    sandrahoang686 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1ab1a3f View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Various cleanup on EA breakout feature branch (#1251) 

    **Related Ticket:** #1154

### Description of Changes
* Fixed to have changes from
https://github.com/NASA-IMPACT/veda-ui/pull/1231/files# which I
accidentally removed when resolving conflicts in main feature branch
* Remove `onClick` from `LinkProperties`
* When something is a link, it doesn't need an onClick event... The
onClick event should be placed on the `Card` Component instead of link
props
* LinkProperties should not be required for the card component. Only
when the card re-routes would it need the linkProperties. For example,
cards on the dataset selector modal dont re-route and we shouldn't have
to pass in linkProps
* Remove try/catch around aoi area/point selection logic and into local
state with useEffect

### Note
Built `v5.9.1-ea.0` off of these changes
Update: Bulit `v5.9.1-ea.1` has been built

### Validation / Testing
* Please make sure Dataset Layer Selection modal and E&A works as
expected
* Please make sure all cards in the dashboard are working as expected
* Make sure external cards link externally and have the external badge
   * Make sure internal cards link internally correctly
   * Make sure Dataset Layer Selection modal selects cards as expected

**NextJs Preview with updated version:**
developmentseed/next-veda-ui#4
    @sandrahoang686
    sandrahoang686 authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    387401f View commit details
    Browse the repository at this point in the history