Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] VEDA Core Features - (E&A) Selected Dataset Layers State to persist (atoms state) #1158

Closed
sandrahoang686 opened this issue Sep 17, 2024 · 0 comments
Closed

[Refactor] VEDA Core Features - (E&A) Selected Dataset Layers State to persist (atoms state) #1158

sandrahoang686 opened this issue Sep 17, 2024 · 0 comments
Assignees
@dzole0311
Labels
veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Sep 17, 2024 •
edited
Loading

This is a tech-debt ticket as a result of #902.

When updating the dataset layers selected on the timeline in E&A feature from Nextjs instance. Dataset layers state and routing should persist accordingly. For example, when removing a layer - the layer should be removed from the map and the route should be updated. Take a look at the timelineDatasetsAtom.

Feature PR/Branch:
veda-ui: #1154
next-veda-ui: NASA-IMPACT/next-veda-ui#4
@sandrahoang686 sandrahoang686 added the veda v2 VEDA Refactor Epic Work label Sep 17, 2024
@sandrahoang686 sandrahoang686 changed the title [Refactor] VEDA Core Features - (E&A) Selected Dataset Layers State to persist [Refactor] VEDA Core Features - (E&A) Selected Dataset Layers State to persist (atoms state) Sep 17, 2024
@sandrahoang686 sandrahoang686 mentioned this issue Sep 17, 2024
Closed
@dzole0311 dzole0311 mentioned this issue Oct 29, 2024
Merged
dzole0311 added a commit that referenced this issue Oct 29, 2024
@dzole0311
[REFACTOR] Import fixes needed for the Next.js instance (#1222)
ef4a30c 
**Related Ticket:** #1158

### Description of Changes
The PR fixes `date-fns` imports which are breaking in Next.js, probably
due to how Next.js handles ESM and CommonJS module imports.

Next.js PR with explanation of the core issue:
NASA-IMPACT/next-veda-ui#8

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
_{Update with info on what can be manually validated in the Deploy
Preview link for example "Validate style updates to selection modal do
NOT affect cards"}_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzole0311 dzole0311

Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dzole0311 @sandrahoang686