Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] VEDA Core Features - (E&A) Make Map Controls work #1155

Closed
sandrahoang686 opened this issue Sep 17, 2024 · 0 comments
Closed

[Refactor] VEDA Core Features - (E&A) Make Map Controls work #1155

sandrahoang686 opened this issue Sep 17, 2024 · 0 comments
Assignees
@dzole0311
Labels
tech debt veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Sep 17, 2024 •
edited
Loading

This is a tech-debt ticket as a result of #902.

Description:
Currently AnalysisMessageControl and CustomAoIControl are commented out from /exploration/components/map because of breaking errors in the NextJs instance. We need to get these controls working as usual in current build and working for nextJs instance.

AnalysisMessageControl Error is related to useThemedControl which needs to be investigated more
CustomAoIControl Errors with...

Source
app/scripts/components/common/map/controls/aoi/custom-aoi-control.tsx (339:28) @ getSelectedIds
337 |    } else {
 338 |      mbDraw.changeMode(SIMPLE_SELECT, {
> 339 |        featureIds: mbDraw.getSelectedIds()
     |                            ^
 340 |      });
 341 |    }
 342 |  }, [main, isDrawing]);

Acceptance Criteria:
Get AnalysisMessageControl and CustomAoIControl working

Feature PR/Branch:
veda-ui: #1154
next-veda-ui: developmentseed/next-veda-ui#4
@sandrahoang686 sandrahoang686 added the veda v2 VEDA Refactor Epic Work label Sep 17, 2024
@sandrahoang686 sandrahoang686 mentioned this issue Sep 17, 2024
Closed
@dzole0311 dzole0311 self-assigned this Sep 23, 2024
@hanbyul-here hanbyul-here mentioned this issue Sep 25, 2024
Closed
@dzole0311 dzole0311 mentioned this issue Oct 21, 2024
Merged
dzole0311 added a commit that referenced this issue Oct 29, 2024
@dzole0311
Fix map controls and resolve Analyses Message issue (#1205)
772b19b 
**Related Ticket:** #1155
#1172

Related Next.js PR:
developmentseed/next-veda-ui#7

### Description of Changes

- Fixed the map controls so that they work in the Next.js instance
- Resolve issue with the Analyses Message display
- Attempted to address the React mount error mentioned in
#1172

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
1. Verify that the AOI controls and Analyses Message work as expected in
both veda-ui and the Next.js instance
2. Verify that adding, deleting a single drawn area, or deleting all
drawn areas works without issues
3. Ensure that analyses execute as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzole0311 dzole0311

Labels
tech debt veda v2 VEDA Refactor Epic Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dzole0311 @sandrahoang686