Clean up the themed controls when unmounted #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Oh interesting, this change breaks custom controls on E&A pages, with an error that |
dzole0311
added a commit
that referenced
this pull request
Oct 29, 2024
**Related Ticket:** #1155 #1172 Related Next.js PR: NASA-IMPACT/next-veda-ui#7 ### Description of Changes - Fixed the map controls so that they work in the Next.js instance - Resolve issue with the Analyses Message display - Attempted to address the React mount error mentioned in #1172 ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing 1. Verify that the AOI controls and Analyses Message work as expected in both veda-ui and the Next.js instance 2. Verify that adding, deleting a single drawn area, or deleting all drawn areas works without issues 3. Ensure that analyses execute as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Clean up ref when themed controls are unmounted
Notes & Questions About Changes
I kept seeing an error that 'cannot update unmounted root' from dev environment of Next instance. I think it is because our themed control doesn't clean up its ref when unmounted. (It happens when I revisit the page while navigating - does not happen on the first landing.)
But I do have some questions 🤔