Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map controls and resolve Analyses Message issue #1205

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented Oct 21, 2024

Related Ticket: #1155 #1172

Related Next.js PR: NASA-IMPACT/next-veda-ui#7

Description of Changes

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

  1. Verify that the AOI controls and Analyses Message work as expected in both veda-ui and the Next.js instance
  2. Verify that adding, deleting a single drawn area, or deleting all drawn areas works without issues
  3. Ensure that analyses execute as expected

@dzole0311 dzole0311 requested review from sandrahoang686 and removed request for sandrahoang686 October 21, 2024 12:32
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit c6aadaf
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/6720a21298d23d00085aa26a
😎 Deploy Preview https://deploy-preview-1205--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dzole0311 dzole0311 marked this pull request as draft October 21, 2024 12:32
@dzole0311 dzole0311 marked this pull request as ready for review October 22, 2024 10:28
@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Oct 28, 2024

@dzole0311 have you tried running this locally with the nextJs instance feature branch code? I've run them both with npm link and kept running into this error? Do you encounter the same?
Screenshot 2024-10-28 at 10 26 12 AM

@dzole0311
Copy link
Collaborator Author

@sandrahoang686 I attempted to fix that issue, but it still occurs. It's unrelated to this PR and we can fix it in a follow-up.

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Oct 28, 2024

@dzole0311 unsure how to test then? could we re-comment out what was causing that error again and add an @TODO to fix that because this would block E&A then. Looking at the original PR hanbyul opened, doesn't look like we have a ticket for it either. We would need to create that as part of a follow-up and have it as part of shipping/exposing E&A

@sandrahoang686
Copy link
Collaborator

@dzole0311 unsure how to test then? could we re-comment out what was causing that error again and add an @TODO to fix that because this would block E&A then. Looking at the original PR hanbyul opened, doesn't look like we have a ticket for it either. We would need to create that as part of a follow-up and have it as part of shipping/exposing E&A

@sandrahoang686
Copy link
Collaborator

@dzole0311 this works in safari for me but in chrome I keep seeing that error even after hard refreshing and going in-cognito so must be something on my end but it looks to be working 👍🏼

@dzole0311
Copy link
Collaborator Author

@sandrahoang686 Thanks again for testing. I removed my fix attempt as it did not fix the issue, and opened a new ticket with details since it occurs in the stories as well as the E&A page: #1221

@dzole0311 dzole0311 merged commit 772b19b into 902-ea-breakout Oct 29, 2024
8 checks passed
@dzole0311 dzole0311 deleted the 1155-fix-map-controls branch October 29, 2024 09:02
@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Oct 30, 2024

aha I think I am seeing the problem you saw @sandrahoang686 . Each component works separately (ex. only modal was used , only EA was used) but when they are put together, they don't seem to stably work together. (Also it works sometimes, and doesn't sometimes. I can't reproduce the error stably 🤔 ) I am looking at the issue 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants