-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix map controls and resolve Analyses Message issue #1205
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
app/scripts/components/common/map/controls/aoi/custom-aoi-control.tsx
Outdated
Show resolved
Hide resolved
app/scripts/components/common/map/controls/aoi/custom-aoi-control.tsx
Outdated
Show resolved
Hide resolved
app/scripts/components/common/map/controls/aoi/custom-aoi-control.tsx
Outdated
Show resolved
Hide resolved
@dzole0311 have you tried running this locally with the nextJs instance feature branch code? I've run them both with npm link and kept running into this error? Do you encounter the same? |
@sandrahoang686 I attempted to fix that issue, but it still occurs. It's unrelated to this PR and we can fix it in a follow-up. |
@dzole0311 unsure how to test then? could we re-comment out what was causing that error again and add an |
|
@dzole0311 this works in safari for me but in chrome I keep seeing that error even after hard refreshing and going in-cognito so must be something on my end but it looks to be working 👍🏼 |
@sandrahoang686 Thanks again for testing. I removed my fix attempt as it did not fix the issue, and opened a new ticket with details since it occurs in the stories as well as the E&A page: #1221 |
aha I think I am seeing the problem you saw @sandrahoang686 . Each component works separately (ex. only modal was used , only EA was used) but when they are put together, they don't seem to stably work together. (Also it works sometimes, and doesn't sometimes. I can't reproduce the error stably 🤔 ) I am looking at the issue 🔍 |
Related Ticket: #1155 #1172
Related Next.js PR: NASA-IMPACT/next-veda-ui#7
Description of Changes
Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing