[Refactor] VEDA Core Features - (E&A) Make DataSelectorModal useable in NextInstance #1156
Comments
|
Re:the |
|
@dzole0311 ahh yes.. I found the same thread and tried that, adding empty tags and divs in multiple areas. Adding them at the container level, wrapping the DataSelectorModal directly and at the next level. But no success.. but I may have not exhausted the places! |
hanbyul-here
added a commit
that referenced
this issue
Oct 28, 2024
**Related Ticket:** #1156 ### Description of Changes - The main reason the data selector modal was not working is ~ again ~ link-related components error. I made it use `linkProperties` props. - I also moved `LinkProperties` type to `types/veda` ### Notes & Questions About Changes I will inline-comment ### Validation / Testing - Build the library from this branch - Use the built asset with this branch (of Next instance) : https://github.com/developmentseed/next-veda-ui/tree/data-selector-modal-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The DataSelectorModal doesn't work in the NextJs instance and breaks. It is currently using the
Modalfrom@devseed-ui/modaland breaks at this line here from the DS library with this error =>Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.We might need to switch the component to use a different
Modalnot from the devseed-ui library to get it working. Possibly USWDS? Either way, we need to get around this error and connect theDataSelectorModalup to the NextJs instance to see if the layers selected persist onto the E&A feature (investigating iftimelineDatasetsAtomworks correctly).Feature PR/Branch:
veda-ui: #1154
next-veda-ui: developmentseed/next-veda-ui#4
The text was updated successfully, but these errors were encountered: