feat(CI): Bitrise M1 Machine and React Native 0.71.6 compatibility upgrade #6327

sethkfman · 2023-05-03T22:08:16Z

Development & PR Process

Follow MetaMask Mobile Coding Standards
Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
Add needs-dev-review label when work is completed
Add needs-qa label when dev review is completed
Add QA Passed label when QA has signed off

Description

This PR enables M1 machines building on Bitrise and addresses specific issue building on Bitrise with the latest React Native upgrade.

A patch was made to provide the Bitrise idk-bundle path into the ReactNative build.gradle project.

Screenshots/Recordings

NA

Issue

Progresses #???

Checklist

[NA] There is a related GitHub issue
[NA] Tests are included if applicable
[NA] Any added code is fully documented

* check gas is recalculate on confirm screen * reset the value of gas before estimating * update snapshot * init engine for failing keyringcontroller * test init * mock transactioncontroller * update test * rebased to main * revert test file name to index * fix failing test

* Edit account name view * addressed review * navigate to edit account name * edit header style * E2e appium/715 edit account name view (#6303) * Fix flaky test * Solve Browserstack errors * Added Gesture.waitAndTap method AddContact and Contacts --------- Co-authored-by: SamuelSalas <[email protected]>

This reverts commit 5542193.

The lint warning about a test title being repeated has been fixed. The two tests were very similar; the titles have been updated to explain how they are different. --------- Co-authored-by: legobeat <[email protected]> Co-authored-by: LeoTM <[email protected]>

- CVE-2023-0842 / GHSA-776f-qx25-q3cc

This reverts commit 2285dd3.

This reverts commit 1cbfeb1.

github-actions · 2023-05-03T22:08:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…rise-machines

Doesn't seem to ever have been useful. Introduced in 69381f0 Prefer `cat`.

Cal-L

Changes LGTM. Some checks are failing though on yarn setup. Try pulling from latest?

…arate component (#6266) * initial commit * draft * cleaned up * lint * include isBalanceZero for fromaddress * fix snapshot * resolved feedback * renaming component names * Update app/components/Views/SendFlow/AddressFrom/AddressFrom.test.tsx Co-authored-by: Ariella Vu <[email protected]> * Update app/components/Views/SendFlow/SendTo/index.js Co-authored-by: Ariella Vu <[email protected]> * removed redudant snapshot * rebased to main * snapshot update * removed podfile change --------- Co-authored-by: Ariella Vu <[email protected]>

* 6.5.0 * fix(on-ramp): Add thunk to handle buy crypto deeplink (#6248) * [FIX] Detox: wallet-tests.spec.js (#6250) * fix wallet-tests.spec.js * add collectible json * updated collectible data for bitrise wallet * fix: invalid title error (#6280) * Update Network Badge to use Badge component of component library (#6254) * Show unsupported token for network when watching tokens (#6258) * [FIX] - Upgrading with deprecated test network selected (#6269) * add migrations to handle deprecated networks * use enums, const instead of strings --------- Co-authored-by: CW <[email protected]> * [FIX] Patch assets-controller to not use BigInt (#6305) * Patch assets-controller to not use BigInt * Update to use public link Co-authored-by: sethkfman <[email protected]> * Update to spell out React Native Co-authored-by: legobeat <[email protected]> * Update to spell out React Native Co-authored-by: legobeat <[email protected]> --------- Co-authored-by: sethkfman <[email protected]> Co-authored-by: legobeat <[email protected]> * build 1104 (#6310) * update changelog --------- Co-authored-by: metamaskbot <[email protected]> Co-authored-by: Pedro Pablo Aste Kompen <[email protected]> Co-authored-by: Chris Wilcox <[email protected]> Co-authored-by: abretonc7s <[email protected]> Co-authored-by: tommasini <[email protected]> Co-authored-by: Cal Leung <[email protected]> Co-authored-by: sethkfman <[email protected]> Co-authored-by: legobeat <[email protected]> Co-authored-by: sethkfman <[email protected]>

* New Crowdin translations by Github Action * PR update * Revert "PR update" This reverts commit 39e533a. --------- Co-authored-by: metamaskbot <[email protected]> Co-authored-by: sethkfman <[email protected]>

* Modify actions bar function and small tidy ups * Commit working Smoke tests * Small changes to tests * Small fixes * hide Keyboard * Fiz sendtoken browserStack * fix sendToken and CreateWalletAccount * add smoke tag to lockreset * wait for no thanks button to exists * increase wait time for term of use modal. * fix wallet displayed step * add time interval to waitFor on no thanks button * add time interval for waitForDisplayed * Add check for terms of use modal loading delay * Update common-steps.js Alter CreateWalletTest to also wait for terms of use text * Add double tap * update tags --------- Co-authored-by: Curtis <[email protected]>

) * add tags to test describe block. * add regression tags to describe block * create methods for Smoke & Regression * update bitrise.yml * fix lint * update changelog

Co-authored-by: legobeat <[email protected]>

* sturdier check * apply feedback * apply feedback * unit test * check phishing and deeplinks * feedback * resolve * url check * more tests --------- Co-authored-by: Curtis David <[email protected]>

* try/catch error generating reports * clean up for reports * Update SendToken.feature * delete feature, was renamed

@confirmations

* Send ETH with Ganache network * Move Ganache initialization to common steps * Remove unneeded async * Update wdio/features/Confirmations/SendEthEOA.feature Co-authored-by: Curtis David <[email protected]> * Add extra step for closing new modal * Add tag @confirmations --------- Co-authored-by: Curtis David <[email protected]>

socket-security · 2023-05-05T21:04:48Z

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Ignoring: @types/[email protected], @types/[email protected]

Pull request alert summary

Issue	Status
Critical CVE	✅ 0 issues
CVE	✅ 0 issues
Mild CVE	✅ 0 issues
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Filesystem access	✅ 0 issues
Network access	✅ 0 issues
Shell access	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
GitHub dependency	✅ 0 issues
No bug tracker	✅ 0 issues
No contributors or author data	✅ 0 issues
No README	✅ 0 issues
Deprecated	✅ 0 issues
New author	✅ 0 issues
Unstable ownership	✅ 0 issues
Non-existent author	✅ 0 issues
Unmaintained	✅ 0 issues
Unpublished package	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues
AI detected security risk	✅ 0 issues
AI warning	✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package	Capability Access	`+/-` Transitive Count	Publisher
@types/[email protected]	None	`+0`	types
@types/[email protected]	None	`+0`	types
[email protected]	None	`+0`	acemarke

🚮 Removed packages: [email protected]

sethkfman · 2023-05-05T21:26:06Z

@SocketSecurity ignore @types/[email protected]
@SocketSecurity ignore @types/[email protected]

blackdevelopa and others added 30 commits April 28, 2023 13:44

enable M1 builds on RN

d6059b5

updated NDK version

d2eb3e0

bump to new workflow step and NDK version

942021d

log out NDK home after install

cf59b2c

Cleanup approve transaction review (#6213)

6240671

Revert "ci: temporarily downgrade ubuntu to 20.04" (#5199)

454fb38

This reverts commit 5542193.

removed version print out step

4f4e82d

update bitrise step version

c8c1825

updated ndk version

f6ecf9f

added local prop file

0166827

update build step and add local.properties file in android

164b363

update local prop script

9d0d760

bump ndk version in metamask gradle

2ddcff6

added strings to be translated for feature #6230 (#6308)

55dc676

bump ndk version

2f7d589

add the NDK path to root gradle

15dc40b

added hard code NDK version and path

178c983

deps: force xml2js@>=0.5.0 via resolutions (#6240)

a65c126

- CVE-2023-0842 / GHSA-776f-qx25-q3cc

updated rootproject properties

2efe717

only update NDK version in patch

ab3b7fb

only update NDK version

2285dd3

removed local prop build step

8444246

Revert "only update NDK version"

1cbfeb1

This reverts commit 2285dd3.

Revert "Revert "only update NDK version""

6bc9c78

This reverts commit 1cbfeb1.

pull NDK path and bitrise script updates

b3a1490

update filepath, script and gradle config to be more dynamic

62a7285

bump to max large M1

f8df358

sethkfman added 2 commits May 3, 2023 15:37

update file path name

f0d8a2e

updated builds with name correction

8f26fa9

sethkfman requested a review from a team as a code owner May 3, 2023 22:08

sethkfman and others added 3 commits May 3, 2023 16:09

update version on install-missing-android-tools bitrise builds

c611cd8

Merge branch 'upgrade/react-native/0.71.6-hermes' into upgrade/RN-bit…

41fe584

…rise-machines

devDeps: Remove concat-cli (#6315)

9167a68

Doesn't seem to ever have been useful. Introduced in 69381f0 Prefer `cat`.

Cal-L approved these changes May 3, 2023

View reviewed changes

blackdevelopa and others added 17 commits May 4, 2023 14:41

On-ramp: Add redux-thunk, refactor successful order handler (#6257)

a601d3a

Fix missing handler on mandatory modal (#6309)

c249e1f

feature(on-ramp): add development environment to onramp-sdk (#6325)

bf454e1

On-ramp: fix missing network name (#6340)

360f8b7

New Crowdin translations by Github Action (#6208)

c92c7b5

* New Crowdin translations by Github Action * PR update * Revert "PR update" This reverts commit 39e533a. --------- Co-authored-by: metamaskbot <[email protected]> Co-authored-by: sethkfman <[email protected]>

[DETOX] Only Run tests with the "smoke" tag in the describe block (#6338

373e478

) * add tags to test describe block. * add regression tags to describe block * create methods for Smoke & Regression * update bitrise.yml * fix lint * update changelog

Fix readme typos (#6275)

ca85e7e

Co-authored-by: legobeat <[email protected]>

sturdier check (#5866)

6541a90

* sturdier check * apply feedback * apply feedback * unit test * check phishing and deeplinks * feedback * resolve * url check * more tests --------- Co-authored-by: Curtis David <[email protected]>

Appium/fix reports video failures (#6343)

eb3eaad

* try/catch error generating reports * clean up for reports * Update SendToken.feature * delete feature, was renamed

Fix yarn watch clean (#6339)

82ebe72

enable proguard for release and QA builds

21931fd

merged main

f39bbb6

Merge branch 'update/enable-proguard' into upgrade/RN-bitrise-machines

db3a4f1

sethkfman merged commit 6eb1aa2 into upgrade/react-native/0.71.6-hermes May 5, 2023

sethkfman deleted the upgrade/RN-bitrise-machines branch May 5, 2023 21:26

github-actions bot locked and limited conversation to collaborators May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(CI): Bitrise M1 Machine and React Native 0.71.6 compatibility upgrade #6327

feat(CI): Bitrise M1 Machine and React Native 0.71.6 compatibility upgrade #6327

sethkfman commented May 3, 2023

github-actions bot commented May 3, 2023

Cal-L left a comment •

edited

Loading

socket-security bot commented May 5, 2023 •

edited

Loading

sethkfman commented May 5, 2023

feat(CI): Bitrise M1 Machine and React Native 0.71.6 compatibility upgrade #6327

feat(CI): Bitrise M1 Machine and React Native 0.71.6 compatibility upgrade #6327

Conversation

sethkfman commented May 3, 2023

github-actions bot commented May 3, 2023

Cal-L left a comment • edited Loading

Choose a reason for hiding this comment

socket-security bot commented May 5, 2023 • edited Loading

sethkfman commented May 5, 2023

Cal-L left a comment •

edited

Loading

socket-security bot commented May 5, 2023 •

edited

Loading