[FIX] Gas is not re-calculated when updating a transaction #5876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
blackdevelopa
force-pushed
the
bg/recal_gas_fee
branch
from
23c13de to
7d07228
Compare
blackdevelopa
added
team-confirmations-secure-ux-PR
blackdevelopa
force-pushed
the
bg/recal_gas_fee
branch
from
569caca to
1d2adb6
Compare
jpuri
reviewed
Mar 21, 2023
blackdevelopa
force-pushed
the
bg/recal_gas_fee
branch
from
cc9f732 to
97b94e6
Compare
blackdevelopa
added
needs-qa
seaona
removed
the
needs-qa
|
PR looks good @blackdevelopa 💯 I've checked switching from ERC20 to ETH and the other way around as well as with ERC721 tokens and they all work fine. A small thing I've noticed is that the button Send is enabled before the gas has updated, but this can be handled in the future, whenever the loading states are consolidated. cc @bschorchit The PR can be merged, just requires to fix some conflicts with a test file. mobile-gas-update-tx.mp4 |
blackdevelopa
force-pushed
the
bg/recal_gas_fee
branch
from
a6eaef4 to
c81e74b
Compare
|
Re-tested again and looks good. I think we can merge it since last changes were due to conflict on a snapshot test |
seaona
added
the
release-6.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
There is a problem with gas calculation when we switch from one type of Send to another (Send ETH/ Send ERC20 / Send NFT). The transaction object retains the previous gas value before attempting to estimate the new gas value. This bug results in non-desired behaviours for both cases.
Screenshots/Recordings
Before
https://recordit.co/oGbCf2W6iy
After
http://recordit.co/xOnFZ3DyQy
Issue
Progresses #5865
Checklist