-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup approve transaction review #6213
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seem isSigningQRObject
isn't passed to the ApproveTransactionReview component and so has no value. So yeah, lgtm. Great find, @jpuri
can we add some unit tests for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a spot check I am I encountering an issue with spending approvals when using Keystone. After tapping approve, the button becomes disabled but the QR modal fails to open and present the composed transaction (to be scanned with Keystone).
iPhone 13 mini
iOS 15.6.1
https://recordit.co/FDiMZnGtz5
Steps to reproduce:
- Import SRP
- bind with Keystone
- Be on testnet or change to it (Sepolia)
- Open test dapp
- tap
Create Token
under Send Token (patience required here) Add token to wallet
andTransfer tokens
(may not be required steps)- tap
Approve tokens
- Tap
Approve
- Note absence of QR
49ae910
to
8dc9271
Compare
Hey @gantunesr , @plasmacorral : thanks a lot for helping with this. @plasmacorral : reported that this PR indeed has issue with QR scanning flow. I have updated the PR to remove QR code related cleanup. I will create a separate PR for cleaning that up. |
From QA changes look good @jpuri . The tooltip is working as before in the different flows (Send ETH / Send token / Contract Interaction ..) and in different networks tooltip.mp4PR can be merged. Whenever I get the Keystone, I can QA the other changes. PS Thank you @plasmacorral for doing an initial QA on the QR code part ! |
Just want to confirm no issues observed with Keystone approval in commit 99fa02b on the same iphone I previously tested with. |
Fixes: #6159
The task was about extracting out tooltip component from ApproveTransactionReview component but I found that these components were actually not being used. Thus I delete them from code.
QA Steps: