-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Send ETH to an EOA using Ganache network on Android #6215
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 🌮 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment
Description
This PR adds an e2e testcase for Android with wdio/appium, using the Ganache network. The test is a Simple send flow to an EOA. For that, it's done the following:
--suite confirmations
Ganache server is started
from common stepsGanache server is stopped
from common steps10000
ETH by default to the generated accounts given the seedphrase we pass it. This seedphrase is defined onAccounts.getValidAccount()
MM_TEST_ACCOUNT_SRP
is not working and not correctly set. For this reason, running local tests we can add a seedphrase, in case the envar does not workseedPhrase: process.env.MM_TEST_ACCOUNT_SRP || 'phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent',
. Seems this is related to issue 762Manual testing steps
adb reverse tcp:8081 tcp:8081
adb reverse tcp:8545 tcp:8545
-- where ganache server runsyarn setup
yarn start:android:qa
yarn test:wdio:android --spec wdio/features/Confirmations/SendEthEOA.feature
Screenshots/Recordings
android-ganache-send-eth.webm
Issue
Checklist